Issue 2779006: Don't run WorkerTests at all under Valgrind....

Issue 2779006: Don't run WorkerTests at all under Valgrind.... (Closed)

Created:
10 years, 6 months ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Alexander Potapenko, Lei Zhang, TVL, oshima, Evan Martin, Robert Sesek

CC:
chromium-reviews, stuartmorgan, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Don't run WorkerTests at all under Valgrind. Excluding them individually appeared to be too hard... BUG=38575 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49286

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -71 lines)			Patch
	M	chrome/test/data/valgrind/ui_tests.gtest.txt	View	1	1 chunk	+4 lines, -71 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

On 2010/06/09 08:32:30, Timur Iskhodzhanov wrote: > LGTM

10 years, 6 months ago (2010-06-09 08:47:34 UTC) #2

TVL

lgtm. sorry, just pushed adding one more to this file this morning before checking my ...

10 years, 6 months ago (2010-06-09 14:01:45 UTC) #5

Timur Iskhodzhanov

Lei, I'm waiting for your LGTM since you wanted to keep the individual filters IIRC.

10 years, 6 months ago (2010-06-09 14:02:58 UTC) #6

Lei Zhang

LGTM since we fixed the wildcard filters and fixing WorkerTest under Valgrind is most likely ...

10 years, 6 months ago (2010-06-09 18:02:04 UTC) #8

Timur Iskhodzhanov

10 years, 6 months ago (2010-06-09 18:08:32 UTC) #9

Commited. I hope WorkerTests won't re-appear anymore until we fix 38575
On 2010/06/09 18:02:04, Lei Zhang wrote:
> LGTM since we fixed the wildcard filters and fixing WorkerTest under Valgrind
is
> most likely all or nothing.

Expand Messages | Collapse Messages