Issue 2779005: Allow creating HTML notifications with the data: scheme. I've confirmed this...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2779005: Allow creating HTML notifications with the data: scheme. I've confirmed this... (Closed)

Created:
10 years, 6 months ago by John Gregg

Modified:
9 years ago

Reviewers:
Andrew T Wilson (Slow)

CC:
chromium-reviews, jam+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Allow creating HTML notifications with the data: scheme. I've confirmed this doesn't open up the same extra privileges as javascript: scheme, which is still disallowed. BUG=32470 TEST=create HTML notifications using data: Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49327

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/renderer/notification_provider.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

So awesome. LGTM.

Expand Messages | Collapse Messages