Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issue 2779005: Allow creating HTML notifications with the data: scheme. I've confirmed this... (Closed)

Created:
10 years, 6 months ago by John Gregg
Modified:
9 years ago
CC:
chromium-reviews, jam+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Allow creating HTML notifications with the data: scheme. I've confirmed this doesn't open up the same extra privileges as javascript: scheme, which is still disallowed. BUG=32470 TEST=create HTML notifications using data: Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49327

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/renderer/notification_provider.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
John Gregg
10 years, 6 months ago (2010-06-09 00:48:57 UTC) #1
Andrew T Wilson (Slow)
10 years, 6 months ago (2010-06-09 01:18:08 UTC) #2
So awesome. LGTM.

Powered by Google App Engine
This is Rietveld 408576698