Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 2776010: Move the crash metrics to the crash reproting lib to avoid a back dependency ... (Closed)

Created:
10 years, 6 months ago by MAD
Modified:
9 years, 7 months ago
Reviewers:
ananta
CC:
chromium-reviews, amit
Visibility:
Public.

Description

Move the crash metrics to the crash reproting lib to avoid a back dependency on Chrome Frame. BUG=0 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49635

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -168 lines) Patch
M chrome_frame/bho.cc View 4 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/chrome_active_document.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/chrome_frame.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome_frame/chrome_frame_automation.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome_frame/crash_metrics.h View 1 chunk +0 lines, -65 lines 0 comments Download
D chrome_frame/crash_metrics.cc View 1 chunk +0 lines, -92 lines 0 comments Download
A + chrome_frame/crash_reporting/crash_metrics.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome_frame/crash_reporting/crash_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/crash_reporting/crash_report.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/crash_reporting/crash_reporting.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome_frame/metrics_service.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
MAD
How about this?
10 years, 6 months ago (2010-06-11 23:57:23 UTC) #1
ananta
LGTM with chrome_frame_automation.cc also fixed to include crash_metrics.h from the new path. The windows try ...
10 years, 6 months ago (2010-06-12 01:07:16 UTC) #2
MAD
Ho, yes, good catch (though I would have looked at the try server results before ...
10 years, 6 months ago (2010-06-12 14:26:21 UTC) #3
MAD
10 years, 6 months ago (2010-06-12 14:39:05 UTC) #4
Oops... I also missed the bho... Should be OK now :-)

Powered by Google App Engine
This is Rietveld 408576698