Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1849)

Unified Diff: chrome/browser/tab_contents/interstitial_page.cc

Issue 2775003: Added plumbing to transport the frame name between RenderViewHost and the Webkit layer. (Closed)
Patch Set: Final version for the record Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tab_contents/interstitial_page.cc
diff --git a/chrome/browser/tab_contents/interstitial_page.cc b/chrome/browser/tab_contents/interstitial_page.cc
index d22aead0b27af18bdfd385dd50095185fdad9446..9c32297dc143060d6d21eb33619dd75449af981f 100644
--- a/chrome/browser/tab_contents/interstitial_page.cc
+++ b/chrome/browser/tab_contents/interstitial_page.cc
@@ -88,7 +88,8 @@ class InterstitialPage::InterstitialPageRVHViewDelegate
// RenderViewHostDelegate::View implementation:
virtual void CreateNewWindow(
int route_id,
- WindowContainerType window_container_type);
+ WindowContainerType window_container_type,
+ const string16& frame_name);
virtual void CreateNewWidget(int route_id,
WebKit::WebPopupType popup_type);
virtual void ShowCreatedWindow(int route_id,
@@ -407,7 +408,7 @@ TabContentsView* InterstitialPage::CreateTabContentsView() {
if (!request_context.get())
request_context = tab()->profile()->GetRequestContext();
- render_view_host_->CreateRenderView(request_context.get());
+ render_view_host_->CreateRenderView(request_context.get(), string16());
view->SetSize(tab_contents_view->GetContainerSize());
// Don't show the interstitial until we have navigated to it.
view->Hide();
@@ -560,7 +561,8 @@ InterstitialPage::InterstitialPageRVHViewDelegate::
void InterstitialPage::InterstitialPageRVHViewDelegate::CreateNewWindow(
int route_id,
- WindowContainerType window_container_type) {
+ WindowContainerType window_container_type,
+ const string16& frame_name) {
NOTREACHED() << "InterstitialPage does not support showing popups yet.";
}
« no previous file with comments | « chrome/browser/tab_contents/background_contents.cc ('k') | chrome/browser/tab_contents/render_view_host_delegate_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698