Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: chrome/browser/renderer_host/render_view_host_delegate.h

Issue 2775003: Added plumbing to transport the frame name between RenderViewHost and the Webkit layer. (Closed)
Patch Set: Final version for the record Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_ 5 #ifndef CHROME_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_
6 #define CHROME_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_ 6 #define CHROME_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 86
87 class View { 87 class View {
88 public: 88 public:
89 // The page is trying to open a new page (e.g. a popup window). The 89 // The page is trying to open a new page (e.g. a popup window). The
90 // window should be created associated with the given route, but it should 90 // window should be created associated with the given route, but it should
91 // not be shown yet. That should happen in response to ShowCreatedWindow. 91 // not be shown yet. That should happen in response to ShowCreatedWindow.
92 // |window_container_type| describes the type of RenderViewHost container 92 // |window_container_type| describes the type of RenderViewHost container
93 // that is requested -- in particular, the window.open call may have 93 // that is requested -- in particular, the window.open call may have
94 // specified 'background' and 'persistent' in the feature string. 94 // specified 'background' and 'persistent' in the feature string.
95 // 95 //
96 // The passed |frame_name| parameter is the name parameter that was passed
97 // to window.open(), and will be empty if none was passed.
98 //
96 // Note: this is not called "CreateWindow" because that will clash with 99 // Note: this is not called "CreateWindow" because that will clash with
97 // the Windows function which is actually a #define. 100 // the Windows function which is actually a #define.
98 // 101 //
99 // NOTE: this takes ownership of @modal_dialog_event 102 // NOTE: this takes ownership of @modal_dialog_event
100 virtual void CreateNewWindow( 103 virtual void CreateNewWindow(
101 int route_id, 104 int route_id,
102 WindowContainerType window_container_type) = 0; 105 WindowContainerType window_container_type,
106 const string16& frame_name) = 0;
103 107
104 // The page is trying to open a new widget (e.g. a select popup). The 108 // The page is trying to open a new widget (e.g. a select popup). The
105 // widget should be created associated with the given route, but it should 109 // widget should be created associated with the given route, but it should
106 // not be shown yet. That should happen in response to ShowCreatedWidget. 110 // not be shown yet. That should happen in response to ShowCreatedWidget.
107 // |popup_type| indicates if the widget is a popup and what kind of popup it 111 // |popup_type| indicates if the widget is a popup and what kind of popup it
108 // is (select, autofill...). 112 // is (select, autofill...).
109 virtual void CreateNewWidget(int route_id, 113 virtual void CreateNewWidget(int route_id,
110 WebKit::WebPopupType popup_type) = 0; 114 WebKit::WebPopupType popup_type) = 0;
111 115
112 // Show a previously created page with the specified disposition and bounds. 116 // Show a previously created page with the specified disposition and bounds.
(...skipping 541 matching lines...) Expand 10 before | Expand all | Expand 10 after
654 virtual bool IsExternalTabContainer() const; 658 virtual bool IsExternalTabContainer() const;
655 659
656 // The RenderView has inserted one css file into page. 660 // The RenderView has inserted one css file into page.
657 virtual void DidInsertCSS() {} 661 virtual void DidInsertCSS() {}
658 662
659 // A different node in the page got focused. 663 // A different node in the page got focused.
660 virtual void FocusedNodeChanged() {} 664 virtual void FocusedNodeChanged() {}
661 }; 665 };
662 666
663 #endif // CHROME_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_ 667 #endif // CHROME_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_
OLDNEW
« no previous file with comments | « chrome/browser/renderer_host/render_view_host.cc ('k') | chrome/browser/renderer_host/render_widget_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698