Issue 2775001: Add enable-video-fullscreen switch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2775001: Add enable-video-fullscreen switch (Closed)

Created:
10 years, 6 months ago by boliu

Modified:
9 years, 6 months ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews, jam+cc_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Visibility:
Public.

Description

Add enable-video-fullscreen switch. Corresponding Webkit patch to make this work is here: https://bugs.webkit.org/show_bug.cgi?id=40317 BUG=16735 TEST=webkitSupportsFullscreen() js call should return true with switch. (Requires webkit patch) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49539

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add NOTIMPLEMENTED() #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -0 lines)			Patch
M	chrome/browser/renderer_host/browser_render_process_host.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/renderer/render_view.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

boliu

Patch for enable-video-fullscreen. Looking at submitting the corresponding patch for Webkit now. (Interestingly, both patches ...

10 years, 6 months ago (2010-06-08 17:46:32 UTC) #1

scherkus (not reviewing)

10 years, 6 months ago (2010-06-08 18:02:43 UTC) #2

LGTM but please update CL description to include:
BUG=16735
TEST=some test

http://codereview.chromium.org/2775001/diff/1/5
File chrome/renderer/render_view.cc (right):

http://codereview.chromium.org/2775001/diff/1/5#newcode1906
chrome/renderer/render_view.cc:1906: void
RenderView::enterFullscreenForNode(const WebKit::WebNode& node) {
add NOTIMPLEMENTED()

http://codereview.chromium.org/2775001/diff/1/5#newcode1909
chrome/renderer/render_view.cc:1909: void
RenderView::exitFullscreenForNode(const WebKit::WebNode& node) {
add NOTIMPLEMENTED()

Expand Messages | Collapse Messages