Issue 2772004: Change tests for string type in RegExpExecStub on all platforms.

Issue 2772004: Change tests for string type in RegExpExecStub on all platforms. (Closed)

Created:
10 years, 6 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein, Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Change tests for string type in RegExpExecStub on all platforms. Committed: http://code.google.com/p/v8/source/detail?r=4854

Patch Set 3 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -78 lines)			Patch
M	src/arm/codegen-arm.cc	View	1 2	3 chunks	+12 lines, -20 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	1 2	2 chunks	+29 lines, -29 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	1 2	1 chunk	+28 lines, -29 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/2772004/diff/5001/6001 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/2772004/diff/5001/6001#newcode9288 src/arm/codegen-arm.cc:9288: __ ubfx(r3, r0, 2, 1); // Extract bit ...

10 years, 6 months ago (2010-06-11 14:26:15 UTC) #2

Erik Corry

http://codereview.chromium.org/2772004/diff/5001/6001 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/2772004/diff/5001/6001#newcode9288 src/arm/codegen-arm.cc:9288: __ ubfx(r3, r0, 2, 1); // Extract bit 2 ...

10 years, 6 months ago (2010-06-14 07:44:12 UTC) #3

William Hesse

10 years, 6 months ago (2010-06-14 10:17:02 UTC) #4

http://codereview.chromium.org/2772004/diff/5001/6001
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/2772004/diff/5001/6001#newcode9288
src/arm/codegen-arm.cc:9288: __ ubfx(r3, r0, 2, 1);  // Extract bit 2 of r0 to
bit 0 of r3.
On 2010/06/11 14:26:15, Lasse Reichstein wrote:
> Is ubfx supported on all platforms that we target?
> It seems to have been introduced in ARMv6T2, which is newer than the
instruction
> list I have available.

No, so I have removed it.  It was also not making a difference.  These two lines
have been removed from the CL.

http://codereview.chromium.org/2772004/diff/5001/6001#newcode9289
src/arm/codegen-arm.cc:9289: __ tst(r3, r3);
On 2010/06/11 14:26:15, Lasse Reichstein wrote:
> Why are these two instructions better than the one move they replace?

They were not, so they have been removed.

Expand Messages | Collapse Messages