Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 2771011: GTK: Always use default frame in popup windows. (Closed)

Created:
10 years, 6 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin, Evan Stade
CC:
chromium-reviews, ben+cc_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

GTK: Always use default frame in popup windows. Now that glen@ has spoken, make popup windows on linux match the XP behaviour by never using themed resources for the window frame. BUG=43938 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49458

Patch Set 1 #

Patch Set 2 : Use functions #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -35 lines) Patch
M chrome/browser/gtk/browser_titlebar.cc View 2 chunks +3 lines, -6 lines 1 comment Download
M chrome/browser/gtk/browser_window_gtk.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/gtk/browser_window_gtk.cc View 1 4 chunks +21 lines, -21 lines 0 comments Download
M chrome/browser/gtk/gtk_theme_provider.h View 4 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/gtk/gtk_theme_provider.cc View 3 chunks +27 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
10 years, 6 months ago (2010-06-10 18:41:17 UTC) #1
Evan Stade
10 years, 6 months ago (2010-06-10 22:06:04 UTC) #2
lgtm

http://codereview.chromium.org/2771011/diff/2001/3001
File chrome/browser/gtk/browser_titlebar.cc (right):

http://codereview.chromium.org/2771011/diff/2001/3001#newcode547
chrome/browser/gtk/browser_titlebar.cc:547: if (app_mode_title_) {
in the interest of minimal tabbing, can you change this to

if (!app_mode_title_)
  return;

Powered by Google App Engine
This is Rietveld 408576698