Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1558)

Issue 2771005: Deactivate all input methods (except keyboard layouts) when screen is locked. (Closed)

Created:
10 years, 6 months ago by Yusuke Sato
Modified:
9 years, 7 months ago
Reviewers:
James Su, oshima
CC:
chromium-os-reviews_chromium.org, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org, satorux1, Zachary Kuznia
Visibility:
Public.

Description

Deactivate all input methods (except keyboard layouts) when screen is locked. Reactivates them when screen is unlocked. Note that if two or more keyboard layouts are active, you can switch layout by pressing the language hot-key (Shift+Alt), though the language indicator ("EN") is not clickable yet. BUG=chromium-os:3936 BUG=chromium-os:2714 TEST=manual Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=49361

Patch Set 1 #

Patch Set 2 : support suspend #

Total comments: 4

Patch Set 3 : fixed all #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -0 lines) Patch
M chrome/browser/chromeos/login/screen_locker.cc View 1 2 4 chunks +67 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Yusuke Sato
10 years, 6 months ago (2010-06-09 13:24:41 UTC) #1
Yusuke Sato
Slightly modified the CL to support suspend state. Please review the patch set #2, not ...
10 years, 6 months ago (2010-06-09 14:20:55 UTC) #2
oshima
lgtm but please add/update comments before commit. http://codereview.chromium.org/2771005/diff/3001/4001 File chrome/browser/chromeos/login/screen_locker.cc (right): http://codereview.chromium.org/2771005/diff/3001/4001#newcode42 chrome/browser/chromeos/login/screen_locker.cc:42: const char ...
10 years, 6 months ago (2010-06-09 15:54:48 UTC) #3
James Su
I think you may also need to save/restore the previous input method.
10 years, 6 months ago (2010-06-09 20:29:35 UTC) #4
oshima
I'm not familiar with exactly how IME APIs work, but looks like it's saving and ...
10 years, 6 months ago (2010-06-09 20:39:27 UTC) #5
Yusuke Sato
On 2010/06/09 20:29:35, James Su wrote: > I think you may also need to save/restore ...
10 years, 6 months ago (2010-06-10 01:50:26 UTC) #6
Yusuke Sato
http://codereview.chromium.org/2771005/diff/3001/4001 File chrome/browser/chromeos/login/screen_locker.cc (right): http://codereview.chromium.org/2771005/diff/3001/4001#newcode42 chrome/browser/chromeos/login/screen_locker.cc:42: const char kValidInputMethodPrefix[] = "xkb:"; On 2010/06/09 15:54:50, oshima ...
10 years, 6 months ago (2010-06-10 01:51:45 UTC) #7
James Su
10 years, 6 months ago (2010-06-10 02:34:44 UTC) #8
Exactly.

在 2010年6月9日 下午6:50, <yusukes@chromium.org>写道:

> On 2010/06/09 20:29:35, James Su wrote:
>
>> I think you may also need to save/restore the previous input method.
>>
>
> Good catch. You mean that we should save/restore previous one (in addition
> to
> the current_input_method().id) so the second IME hot-key, Ctrl+space, works
> correctly even after unlocking, right?
>
> I've added TODO for the issue. I'll do it in a separate CL.
>
>
>
> http://codereview.chromium.org/2771005/show
>

Powered by Google App Engine
This is Rietveld 408576698