Deactivate all input methods (except keyboard layouts) when screen is locked.

Deactivate all input methods (except keyboard layouts) when screen is locked.
Reactivates them when screen is unlocked.

Note that if two or more keyboard layouts are active, you can switch layout by pressing the language hot-key (Shift+Alt), though the language indicator ("EN") is not clickable yet.

BUG=chromium-os:3936
BUG=chromium-os:2714
TEST=manual

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=49361

[Yusuke Sato, 2010-06-09 14:20:55]

Slightly modified the CL to support suspend state.
Please review the patch set #2, not #1.

[oshima, 2010-06-09 15:54:48]

lgtm but please add/update comments before commit.

http://codereview.chromium.org/2771005/diff/3001/4001
File chrome/browser/chromeos/login/screen_locker.cc (right):

http://codereview.chromium.org/2771005/diff/3001/4001#newcode42
chrome/browser/chromeos/login/screen_locker.cc:42: const char
kValidInputMethodPrefix[] = "xkb:";
can you add comment please?

http://codereview.chromium.org/2771005/diff/3001/4001#newcode86
chrome/browser/chromeos/login/screen_locker.cc:86: // The LockScreen() is called
when the OS resumed from suspend, and in
This comment is not correct. LockScreen is called when suspended.

[James Su, 2010-06-09 20:29:35]

I think you may also need to save/restore the previous input method.

[oshima, 2010-06-09 20:39:27]

I'm not familiar with exactly how IME APIs work, but looks like it's saving and
restoring. I may be wrong though.

On 2010/06/09 20:29:35, James Su wrote:
> I think you may also need to save/restore the previous input method.

[Yusuke Sato, 2010-06-10 01:50:26]

On 2010/06/09 20:29:35, James Su wrote:
> I think you may also need to save/restore the previous input method.

Good catch. You mean that we should save/restore previous one (in addition to
the current_input_method().id) so the second IME hot-key, Ctrl+space, works
correctly even after unlocking, right?

I've added TODO for the issue. I'll do it in a separate CL.

[Yusuke Sato, 2010-06-10 01:51:45]

http://codereview.chromium.org/2771005/diff/3001/4001
File chrome/browser/chromeos/login/screen_locker.cc (right):

http://codereview.chromium.org/2771005/diff/3001/4001#newcode42
chrome/browser/chromeos/login/screen_locker.cc:42: const char
kValidInputMethodPrefix[] = "xkb:";
On 2010/06/09 15:54:50, oshima wrote:
> can you add comment please?

Done.

http://codereview.chromium.org/2771005/diff/3001/4001#newcode86
chrome/browser/chromeos/login/screen_locker.cc:86: // The LockScreen() is called
when the OS resumed from suspend, and in
On 2010/06/09 15:54:50, oshima wrote:
> This comment is not correct. LockScreen is called when suspended.

Done.

[James Su, 2010-06-10 02:34:44]

Exactly.

在 2010年6月9日 下午6:50， <yusukes@chromium.org>写道：

> On 2010/06/09 20:29:35, James Su wrote:
>
>> I think you may also need to save/restore the previous input method.
>>
>
> Good catch. You mean that we should save/restore previous one (in addition
> to
> the current_input_method().id) so the second IME hot-key, Ctrl+space, works
> correctly even after unlocking, right?
>
> I've added TODO for the issue. I'll do it in a separate CL.
>
>
>
> http://codereview.chromium.org/2771005/show
>