Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 2771001: Use static type information on x64 in LikelySmiBinaryOperation (Closed)

Created:
10 years, 6 months ago by William Hesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Use static type information on x64 in LikelySmiBinaryOperation. Refactor check for smi operands, using type information, on ia32 and x64. Committed: http://code.google.com/p/v8/source/detail?r=4831

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -60 lines) Patch
M src/ia32/codegen-ia32.h View 1 chunk +10 lines, -0 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 5 chunks +42 lines, -54 lines 0 comments Download
M src/x64/codegen-x64.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 5 chunks +25 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
William Hesse
10 years, 6 months ago (2010-06-08 14:41:42 UTC) #1
Vyacheslav Egorov (Chromium)
LGTM http://codereview.chromium.org/2771001/diff/1/2 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/2771001/diff/1/2#newcode7227 src/x64/codegen-x64.cc:7227: } ia32 uses mighty CheckTwoForSminess function which also ...
10 years, 6 months ago (2010-06-08 14:50:04 UTC) #2
fschneider
Drive-by comment: Don't forget to also do ConstantSmiBinaryOperation. But it's fine to do this as ...
10 years, 6 months ago (2010-06-09 09:08:40 UTC) #3
William Hesse
I added a lot of refactoring to this, and added use of typeinfo to the ...
10 years, 6 months ago (2010-06-09 09:24:59 UTC) #4
Vyacheslav Egorov (Chromium)
10 years, 6 months ago (2010-06-09 10:44:19 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698