Issue 277004: Move IDS_NOTIFICATION_PERMISSIONS to generated_resources.grd

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 277004: Move IDS_NOTIFICATION_PERMISSIONS to generated_resources.grd (Closed)

Created:
11 years, 2 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
John Gregg, TVL

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Move IDS_NOTIFICATION_PERMISSIONS to generated_resources.grd. This string never belonged in chromium_strings.grd because it's not branding-dependent. Placing it in chromium_strings.grd but not google_chrome_strings.grd caused the two strings files to become out of sync, which is actually really really bad. BUG=24776 TEST=Application name shown in Mac menu bar should be Chrome, not Google Chrome Helper or anything else Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28980

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -16 lines)			Patch
	M	chrome/app/chromium_strings.grd	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	chrome/app/generated_resources.grd	View		1 chunk	+16 lines, -13 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages