Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 2770007: Fix for DrawArrays, DrawElements. Removed the check... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/gles2_cmd_decoder.cc
===================================================================
--- gpu/command_buffer/service/gles2_cmd_decoder.cc (revision 49090)
+++ gpu/command_buffer/service/gles2_cmd_decoder.cc (working copy)
@@ -3007,8 +3007,11 @@
}
bool GLES2DecoderImpl::IsDrawValid(GLuint max_vertex_accessed) {
- if (!current_program_ || current_program_->IsDeleted() ||
- !current_program_->IsValid()) {
+ // NOTE: We specifically do not check current_program->IsValid() because
+ // it could never be invalid since glUseProgram would have failed. While
+ // glLinkProgram could later mark the program as invalid the previous
+ // valid program will stull function if it is still the current program.
apatrick 2010/06/09 17:52:53 stull -> still
+ if (!current_program_ || current_program_->IsDeleted()) {
// The program does not exist.
// But GL says no ERROR.
return false;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698