Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2770007: Fix for DrawArrays, DrawElements. Removed the check... (Closed)

Created:
10 years, 6 months ago by greggman
Modified:
9 years, 7 months ago
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Fix for DrawArrays, DrawElements. Removed the check for an invalid program. The check is already in UseProgram. If that check passes the program is "installed" at which point it, even if LinkProgram is called and fails, marking the program as invalid, the previously installed program is still in use until UseProgram is called. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49293

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +5 lines, -2 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
greggman
10 years, 6 months ago (2010-06-09 17:09:55 UTC) #1
apatrick
10 years, 6 months ago (2010-06-09 17:52:53 UTC) #2
lgtm

http://codereview.chromium.org/2770007/diff/1/2
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

http://codereview.chromium.org/2770007/diff/1/2#newcode3013
gpu/command_buffer/service/gles2_cmd_decoder.cc:3013: // valid program will
stull function if it is still the current program.
stull -> still

Powered by Google App Engine
This is Rietveld 408576698