Issue 2770003: Changed syncable::PASSWORD to syncable::PASSWORDS for consistency

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2770003: Changed syncable::PASSWORD to syncable::PASSWORDS for consistency (Closed)

Created:
10 years, 6 months ago by akalin

Modified:
9 years, 7 months ago

Reviewers:
chron_chromium.org

CC:
chromium-reviews, Paweł Hajdan Jr., ncarter (slow), ben+cc_chromium.org, tim (not reviewing), idana

Visibility:
Public.

Description

Changed syncable::PASSWORD to syncable::PASSWORDS for consistency with other constants. BUG=none TEST=trybots committed as http://src.chromium.org/viewvc/chrome?view=rev&revision=49231

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -16 lines)			Patch
M	chrome/browser/sync/engine/syncapi.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/glue/data_type_manager_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/password_change_processor.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/glue/password_data_type_controller.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/password_model_associator.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/password_model_associator.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/glue/sync_backend_host.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/profile_sync_service_password_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/syncable/model_type.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/syncable/model_type.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

chron_chromium.org

10 years, 6 months ago (2010-06-08 23:12:53 UTC) #2

LGTM

On Tue, Jun 8, 2010 at 1:00 PM, <akalin@chromium.org> wrote:

> Reviewers: chron_chromium.org,
>
> Message:
> +chron for review
>
> Description:
> Changed syncable::PASSWORD to syncable::PASSWORDS for consistency
> with other constants.
>
> BUG=none
> TEST=trybots
>
> Please review this at http://codereview.chromium.org/2770003/show
>
> Affected files:
>  M chrome/browser/sync/engine/syncapi.cc
>  M chrome/browser/sync/glue/data_type_manager_impl.cc
>  M chrome/browser/sync/glue/password_change_processor.cc
>  M chrome/browser/sync/glue/password_data_type_controller.h
>  M chrome/browser/sync/glue/password_model_associator.h
>  M chrome/browser/sync/glue/password_model_associator.cc
>  M chrome/browser/sync/glue/sync_backend_host.h
>  M chrome/browser/sync/profile_sync_service.cc
>  M chrome/browser/sync/profile_sync_service_password_unittest.cc
>  M chrome/browser/sync/syncable/model_type.h
>  M chrome/browser/sync/syncable/model_type.cc
>
>
>


-- 
As seen on TV

Expand Messages | Collapse Messages