Mac/clang: Possibly contentious changes.

chrome/browser/geolocation/wifi_data_provider_corewlan_mac.mm

Index: chrome/browser/geolocation/wifi_data_provider_corewlan_mac.mm
diff --git a/chrome/browser/geolocation/wifi_data_provider_corewlan_mac.mm b/chrome/browser/geolocation/wifi_data_provider_corewlan_mac.mm
index 955f86e33133787c95705aba7ea6d63220a9edd8..6d1ddf3da7f19760433e7355a34de9d2c3828898 100644
--- a/chrome/browser/geolocation/wifi_data_provider_corewlan_mac.mm
+++ b/chrome/browser/geolocation/wifi_data_provider_corewlan_mac.mm
@@ -29,16 +29,16 @@
 @end
 
 @interface CWNetwork : NSObject <NSCopying, NSCoding>
-@property(readonly) NSString* ssid;
-@property(readonly) NSString* bssid;
-@property(readonly) NSData* bssidData;
-@property(readonly) NSNumber* securityMode;
-@property(readonly) NSNumber* phyMode;
-@property(readonly) NSNumber* channel;
-@property(readonly) NSNumber* rssi;
-@property(readonly) NSNumber* noise;
-@property(readonly) NSData* ieData;
-@property(readonly) BOOL isIBSS;
+@property (nonatomic, readonly) NSString* ssid;
+@property (nonatomic, readonly) NSString* bssid;
+@property (nonatomic, readonly) NSData* bssidData;
+@property (nonatomic, readonly) NSNumber* securityMode;
+@property (nonatomic, readonly) NSNumber* phyMode;
+@property (nonatomic, readonly) NSNumber* channel;
+@property (nonatomic, readonly) NSNumber* rssi;
+@property (nonatomic, readonly) NSNumber* noise;
+@property (nonatomic, readonly) NSData* ieData;
+@property (nonatomic, readonly) BOOL isIBSS;

[joth, 2010/06/15 18:44:25]

quick sanity check - as mentioned in the comment this section is based on the
interface declared in
/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/CoreWLAN.framework/Versions/A/Headers/CWNetwork.h

1/ will adding nonatomic impact compatibility with that interface?
2/ will the fact that interface lacks nonatomic cause problems when we switch to
used the 10.6 SDK headers directly (as oer the above TODO)?

[Mark Mentovai, 2010/06/15 19:30:04]

joth wrote:
We should remove nonatomic from these, but to answer your questions:
 
No.
Not directly. What will cause problems is a duplicate definition of the
@interface, but we face that problem regardless of whether the properties are
specified as atomic or not.

Clearly, we are not #importing (directly or indirectly) <CoreWLAN/CWNetwork.h>
anywhere relevant to this file with the 10.6 SDK now, or the 10.6 SDK build
would already be broken. (Some developers, myself included, routinely build and
test this configuration.)

 - (BOOL)isEqualToNetwork:(CWNetwork*)network;
 @end