Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: chrome/browser/cocoa/location_bar_view_mac.mm

Issue 2769014: Mac/clang: Possibly contentious changes. (Closed)
Patch Set: comments2 Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/location_bar_view_mac.mm
diff --git a/chrome/browser/cocoa/location_bar_view_mac.mm b/chrome/browser/cocoa/location_bar_view_mac.mm
index 9be750a39cb809957a90304a1b8246bdd8e2854b..fd4d87a1c15e0608c85d8a1f38e7c7459b52f7a9 100644
--- a/chrome/browser/cocoa/location_bar_view_mac.mm
+++ b/chrome/browser/cocoa/location_bar_view_mac.mm
@@ -492,7 +492,7 @@ void LocationBarViewMac::Observe(NotificationType type,
}
}
-void LocationBarViewMac::PostNotification(const NSString* notification) {
+void LocationBarViewMac::PostNotification(NSString* notification) {
[[NSNotificationCenter defaultCenter] postNotificationName:notification
object:[NSValue valueWithPointer:this]];
}
@@ -625,7 +625,7 @@ void LocationBarViewMac::StarIconView::OnMousePressed(NSRect bounds) {
command_updater_->ExecuteCommand(IDC_BOOKMARK_PAGE);
}
-const NSString* LocationBarViewMac::StarIconView::GetToolTip() {
+NSString* LocationBarViewMac::StarIconView::GetToolTip() {
return tooltip_.get();
}
@@ -791,7 +791,7 @@ void LocationBarViewMac::PageActionImageView::SetToolTip(std::string tooltip) {
SetToolTip(base::SysUTF8ToNSString(tooltip));
}
-const NSString* LocationBarViewMac::PageActionImageView::GetToolTip() {
+NSString* LocationBarViewMac::PageActionImageView::GetToolTip() {
return tooltip_.get();
}
@@ -874,7 +874,7 @@ void LocationBarViewMac::ContentSettingImageView::OnMousePressed(NSRect bounds)
anchoredAt:anchor] showWindow:nil];
}
-const NSString* LocationBarViewMac::ContentSettingImageView::GetToolTip() {
+NSString* LocationBarViewMac::ContentSettingImageView::GetToolTip() {
return tooltip_.get();
}

Powered by Google App Engine
This is Rietveld 408576698