Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: chrome/browser/cocoa/bookmark_editor_base_controller.mm

Issue 2769014: Mac/clang: Possibly contentious changes. (Closed)
Patch Set: comments2 Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/bookmark_editor_base_controller.mm
diff --git a/chrome/browser/cocoa/bookmark_editor_base_controller.mm b/chrome/browser/cocoa/bookmark_editor_base_controller.mm
index be367aecdd841e3c80fe61b957f9165b54f6ba5e..51612cebbd8ef7b19ec03cf12a572809804514e4 100644
--- a/chrome/browser/cocoa/bookmark_editor_base_controller.mm
+++ b/chrome/browser/cocoa/bookmark_editor_base_controller.mm
@@ -332,10 +332,6 @@ class BookmarkEditorBaseControllerBridge : public BookmarkModelObserver {
return folderTreeArray_.get();
}
-- (void)setFolderTreeArray:(NSArray*)folderTreeArray {
- folderTreeArray_.reset([folderTreeArray retain]);
-}
-
- (NSArray*)tableSelectionPaths {
return tableSelectionPaths_.get();
}
@@ -420,7 +416,7 @@ class BookmarkEditorBaseControllerBridge : public BookmarkModelObserver {
const BookmarkNode* rootNode = model->root_node();
NSMutableArray* baseArray = [self addChildFoldersFromNode:rootNode];
DCHECK(baseArray);
- [self setFolderTreeArray:baseArray];
+ folderTreeArray_.reset([baseArray retain]);
}
- (void)modelChangedPreserveSelection:(BOOL)preserve {

Powered by Google App Engine
This is Rietveld 408576698