Issue 2769011: Some preparation work towards the gclient.py refactor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2769011: Some preparation work towards the gclient.py refactor. (Closed)

Created:
10 years, 6 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews

Visibility:
Public.

Description

Some preparation work towards the gclient.py refactor. Switch "" usage to '' to please Brad. Didn't change gclient.py yet because it will conflict with the refactor. TEST=unit tests still pass. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49545

Patch Set 1 #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+101 lines, -102 lines)			Patch
	M	gclient.py	View		15 chunks	+88 lines, -89 lines	0 comments	Download
	M	gclient_utils.py	View		6 chunks	+13 lines, -13 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

bradn

10 years, 6 months ago (2010-06-11 17:17:51 UTC) #2

LGTM

http://codereview.chromium.org/2769011/diff/1/3
File gclient_utils.py (right):

http://codereview.chromium.org/2769011/diff/1/3#newcode349
gclient_utils.py:349: print 'Can\'t find', config_file
Technically the style guide /gpylint allows alternate quotes, in the case where
it reduces the escaping in the string.

Expand Messages | Collapse Messages