Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Issue 2769001: Factor out StringsStorage from CpuProfilesCollection. (Closed)

Created:
10 years, 6 months ago by mnaganov (inactive)
Modified:
9 years, 7 months ago
CC:
v8-dev, tfarina
Visibility:
Public.

Description

Factor out StringsStorage from CpuProfilesCollection. Committed: http://code.google.com/p/v8/source/detail?r=4826

Patch Set 1 #

Total comments: 4

Patch Set 2 : Comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -36 lines) Patch
M src/profile-generator.h View 1 3 chunks +26 lines, -8 lines 0 comments Download
M src/profile-generator.cc View 1 4 chunks +32 lines, -28 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mnaganov (inactive)
10 years, 6 months ago (2010-06-08 12:47:57 UTC) #1
tfarina
http://codereview.chromium.org/2769001/diff/1/2 File src/profile-generator.cc (right): http://codereview.chromium.org/2769001/diff/1/2#newcode115 src/profile-generator.cc:115: } else { I guess we could just return ...
10 years, 6 months ago (2010-06-08 16:14:57 UTC) #2
Søren Thygesen Gjesse
LGTM
10 years, 6 months ago (2010-06-09 06:45:09 UTC) #3
mnaganov (inactive)
10 years, 6 months ago (2010-06-09 06:58:30 UTC) #4
http://codereview.chromium.org/2769001/diff/1/2
File src/profile-generator.cc (right):

http://codereview.chromium.org/2769001/diff/1/2#newcode115
src/profile-generator.cc:115: } else {
On 2010/06/08 16:14:58, tfarina wrote:
> I guess we could just return "";
> 
> No need of the else here.

Done.

http://codereview.chromium.org/2769001/diff/1/3
File src/profile-generator.h (right):

http://codereview.chromium.org/2769001/diff/1/3#newcode67
src/profile-generator.h:67: private:
On 2010/06/08 16:14:58, tfarina wrote:
> please, could add a blank line above.

Done.

Powered by Google App Engine
This is Rietveld 408576698