Issue 2769001: Factor out StringsStorage from CpuProfilesCollection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2769001: Factor out StringsStorage from CpuProfilesCollection. (Closed)

Created:
10 years, 6 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev, tfarina

Visibility:
Public.

Description

Factor out StringsStorage from CpuProfilesCollection. Committed: http://code.google.com/p/v8/source/detail?r=4826

Patch Set 2 : Comments addressed #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -36 lines)			Patch
	M	src/profile-generator.h	View	1	3 chunks	+26 lines, -8 lines	0 comments	Download
	M	src/profile-generator.cc	View	1	4 chunks	+32 lines, -28 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tfarina

http://codereview.chromium.org/2769001/diff/1/2 File src/profile-generator.cc (right): http://codereview.chromium.org/2769001/diff/1/2#newcode115 src/profile-generator.cc:115: } else { I guess we could just return ...

10 years, 6 months ago (2010-06-08 16:14:57 UTC) #2

mnaganov (inactive)

10 years, 6 months ago (2010-06-09 06:58:30 UTC) #4

http://codereview.chromium.org/2769001/diff/1/2
File src/profile-generator.cc (right):

http://codereview.chromium.org/2769001/diff/1/2#newcode115
src/profile-generator.cc:115: } else {
On 2010/06/08 16:14:58, tfarina wrote:
> I guess we could just return "";
> 
> No need of the else here.

Done.

http://codereview.chromium.org/2769001/diff/1/3
File src/profile-generator.h (right):

http://codereview.chromium.org/2769001/diff/1/3#newcode67
src/profile-generator.h:67: private:
On 2010/06/08 16:14:58, tfarina wrote:
> please, could add a blank line above.

Done.

Expand Messages | Collapse Messages

Issue 2769001: Factor out StringsStorage from CpuProfilesCollection. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Comments addressed #

Messages