Issue 2767011: Pack firmware into an image and do update in factory install (separated git).

Issue 2767011: Pack firmware into an image and do update in factory install (separated git). (Closed)

Created:
10 years, 6 months ago by Tom Wai-Hong Tam

Modified:
9 years, 5 months ago

Reviewers:
Tammo Spalink, Nick Sanders, adlr

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git/memento_softwareupdate.git

Visibility:
Public.

Description

Pack firmware into an image and do update in factory install (separated git). Since different platforms have different instructions to update their firmware. In order not to depend on the install shim, we pack all firmware update files into a single file, i.e. an executable shell script with embedded files. The original CL (http://codereview.chromium.org/2366001) is reviewed and is broken down into 5 CLs. This is one of them.

Patch Set 1 #

Patch Set 2 : just run the script #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	memento_updater.sh	View	1	2 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

adlr

On Fri, Jun 11, 2010 at 12:13 AM, <waihong@chromium.org> wrote: > Reviewers: adlr, tammo, Nick ...

10 years, 6 months ago (2010-06-11 17:18:11 UTC) #2

On Fri, Jun 11, 2010 at 12:13 AM, <waihong@chromium.org> wrote:

> Reviewers: adlr, tammo, Nick Sanders,
>
> Description:
> Pack firmware into an image and do update in factory install (separated
> git).
>
> Since different platforms have different instructions to update their
> firmware.
> In order not to depend on the install shim, we pack all firmware update
> files
> into a single file, i.e. an executable shell script with embedded files.
>
> The original CL (http://codereview.chromium.org/2366001) is reviewed and
> is
> broken down into 5 CLs. This is one of them.
>
> Please review this at http://codereview.chromium.org/2767011/show
>
> SVN Base: ssh://git@chromiumos-git/memento_softwareupdate.git
>
> Affected files:
>  M memento_updater.sh
>
>
> Index: memento_updater.sh
> diff --git a/memento_updater.sh b/memento_updater.sh
> index
>
b39a3ce0fb23aa51fa36c8f6514542033e3dbe78..d5ff4478e4dfadc0014534aa4fc58025c6d92a42
> 100755
> --- a/memento_updater.sh
> +++ b/memento_updater.sh
> @@ -175,7 +175,7 @@ then
>   log "didnt find good local device. local: $LOCAL_DEV install:
> $INSTALL_DEV"
>   exit 1
>  fi
> -if [ ! -b "$INSTALL_DEV" ]
> +if [ ! -b "$INSTALL_DEV" -a ! "${FLAGS_force_track}" = "firmware-channel"
> ]
>  then
>   log "didnt find good install device. local: $LOCAL_DEV install:
> $INSTALL_DEV"
>   exit 1
> @@ -320,6 +320,15 @@ if [ $FLAGS_skip_postinst -eq $FLAGS_FALSE ]; then
>   # postinstall on new partition succeeded.
>  fi
>
> +if [ "${FLAGS_force_track}" = "firmware-channel" ]; then
> +  log execute firmware-install script
> +  INSTALL_SCRIPT="${FLAGS_dst_partition}"
> +  chmod +x "${INSTALL_SCRIPT}"
> +  pushd "$(dirname "${INSTALL_SCRIPT}")" > /dev/null
> +  eval "${INSTALL_SCRIPT}" >> "$MEMENTO_AU_LOG"
>

if you want to run the script, why not just do:

./"${INSTALL_SCRIPT}" >> ...


> +  popd > /dev/null
> +fi
> +
>  if [ -z "${FLAGS_dst_partition}" ]; then
>   # mark update as complete so we don't try to update again
>   touch "$UPDATED_COMPLETED_FILE"
>
>
>

Tom Wai-Hong Tam

You are right. Fixed it. On Sat, Jun 12, 2010 at 1:17 AM, Andrew de ...

10 years, 6 months ago (2010-06-12 01:48:51 UTC) #3

You are right. Fixed it.

On Sat, Jun 12, 2010 at 1:17 AM, Andrew de los Reyes <adlr@chromium.org>wrote:

>
>
> On Fri, Jun 11, 2010 at 12:13 AM, <waihong@chromium.org> wrote:
>
>> Reviewers: adlr, tammo, Nick Sanders,
>>
>> Description:
>> Pack firmware into an image and do update in factory install (separated
>> git).
>>
>> Since different platforms have different instructions to update their
>> firmware.
>> In order not to depend on the install shim, we pack all firmware update
>> files
>> into a single file, i.e. an executable shell script with embedded files.
>>
>> The original CL (http://codereview.chromium.org/2366001) is reviewed and
>> is
>> broken down into 5 CLs. This is one of them.
>>
>> Please review this at http://codereview.chromium.org/2767011/show
>>
>> SVN Base: ssh://git@chromiumos-git/memento_softwareupdate.git
>>
>> Affected files:
>>  M memento_updater.sh
>>
>>
>> Index: memento_updater.sh
>> diff --git a/memento_updater.sh b/memento_updater.sh
>> index
>>
b39a3ce0fb23aa51fa36c8f6514542033e3dbe78..d5ff4478e4dfadc0014534aa4fc58025c6d92a42
>> 100755
>> --- a/memento_updater.sh
>> +++ b/memento_updater.sh
>> @@ -175,7 +175,7 @@ then
>>   log "didnt find good local device. local: $LOCAL_DEV install:
>> $INSTALL_DEV"
>>   exit 1
>>  fi
>> -if [ ! -b "$INSTALL_DEV" ]
>> +if [ ! -b "$INSTALL_DEV" -a ! "${FLAGS_force_track}" = "firmware-channel"
>> ]
>>  then
>>   log "didnt find good install device. local: $LOCAL_DEV install:
>> $INSTALL_DEV"
>>   exit 1
>> @@ -320,6 +320,15 @@ if [ $FLAGS_skip_postinst -eq $FLAGS_FALSE ]; then
>>   # postinstall on new partition succeeded.
>>  fi
>>
>> +if [ "${FLAGS_force_track}" = "firmware-channel" ]; then
>> +  log execute firmware-install script
>> +  INSTALL_SCRIPT="${FLAGS_dst_partition}"
>> +  chmod +x "${INSTALL_SCRIPT}"
>> +  pushd "$(dirname "${INSTALL_SCRIPT}")" > /dev/null
>> +  eval "${INSTALL_SCRIPT}" >> "$MEMENTO_AU_LOG"
>>
>
> if you want to run the script, why not just do:
>
> ./"${INSTALL_SCRIPT}" >> ...
>
>
>> +  popd > /dev/null
>> +fi
>> +
>>  if [ -z "${FLAGS_dst_partition}" ]; then
>>   # mark update as complete so we don't try to update again
>>   touch "$UPDATED_COMPLETED_FILE"
>>
>>
>>
>

LGTM

Expand Messages | Collapse Messages