Issue 2765005: revert cl 49121 since the way of using glEglImageTargetTexture2DOES is undefined and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2765005: revert cl 49121 since the way of using glEglImageTargetTexture2DOES is undefined and (Closed)

Created:
10 years, 6 months ago by wjia(left Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kenneth Waters, jiesun, Alpha Left Google

CC:
chromium-reviews, scherkus (not reviewing), fbarchard, pam+watch_chromium.org, awong

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

revert cl 49121 since the way of using glEglImageTargetTexture2DOES is undefined and it crashes randomly. BUG=none TEST=dev platform Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49318

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -23 lines)			Patch
	M	media/tools/player_x11/gles_video_renderer.h	View		2 chunks	+1 line, -1 line	0 comments	Download
	M	media/tools/player_x11/gles_video_renderer.cc	View		5 chunks	+23 lines, -22 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jiesun

LGTM. but I actually never meet the crash problem myself.

10 years, 6 months ago (2010-06-09 21:08:00 UTC) #2

Alpha Left Google

On 2010/06/09 21:05:46, wjia wrote: > Looks like this is a problem in the driver, ...

10 years, 6 months ago (2010-06-09 21:08:14 UTC) #3

wjia(left Chromium)

According to Ken, it's undefined use case. It's likely vendor will not fix it since ...

10 years, 6 months ago (2010-06-09 21:10:52 UTC) #4

Kenneth Waters

10 years, 6 months ago (2010-06-09 21:16:13 UTC) #5

Just to clarify myself.  There is a bug in the driver, the driver is not allowed
to crash; but, it is allowed to draw garbage, since the values in the EGLImage
Siblings are undefined after the call to glEGLImageTargetTexture2DOES.

Even if it did work I would be worried about performance because a GL driver
that does not do texture renaming will need to synchronize on every call to
glEGLImageTargetTexture2DOES.  Additionally there is the overhead of setting up
and tearing down EGLImage siblings which can be completely avoided.

Expand Messages | Collapse Messages