ipc/ipc_channel_posix.cc - Issue 2762014: Mac: clang build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_channel_posix.cc

Issue 2762014: Mac: clang build (Closed)

Patch Set: comments Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ipc/ipc_channel_posix.cc

diff --git a/ipc/ipc_channel_posix.cc b/ipc/ipc_channel_posix.cc

index e4852b4de321a0d7536e993fab5162b93dfd24ce..1c1b4e6817ad01cce9023e09cd97ae297f3feef9 100644

--- a/ipc/ipc_channel_posix.cc

+++ b/ipc/ipc_channel_posix.cc

@@ -135,8 +135,7 @@ int ChannelNameToFD(const std::string& channel_id) {

}

//------------------------------------------------------------------------------

-sockaddr_un sizecheck;

-const size_t kMaxPipeNameLength = sizeof(sizecheck.sun_path);

+const size_t kMaxPipeNameLength = sizeof(((sockaddr_un*)0)->sun_path);

Evan Martin 2010/09/22 00:03:47 Is this really the best way to accomplish this? T

Nico 2010/09/22 00:06:25 I asked on cfe-dev, and this is what The Chris Lat

// Creates a Fifo with the specified name ready to listen on.

bool CreateServerFifo(const std::string& pipe_name, int* server_listen_fd) {