Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8132)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/common.gypi

Issue 2762014: Mac: clang build (Closed)
Patch Set: comments Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/autofill/autofill_text_field_mac.mm » ('j') | chrome/browser/cocoa/authorization_util.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index d81c56765b1599441acc6bd3ef49a422769b909c..66294115636fcab476cdc6928c45540161ce0cb2 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1234,6 +1234,13 @@
['chromium_mac_pch', {'GCC_PRECOMPILE_PREFIX_HEADER': 'YES'},
{'GCC_PRECOMPILE_PREFIX_HEADER': 'NO'}
],
+ ['clang==1', {
Mark Mentovai 2010/09/22 16:38:36 Do we need this for anything else in the Mac build
Nico 2010/09/22 16:41:08 There's more: gtest.gyp and skia.gyp check this an
+ 'WARNING_CFLAGS': [
+ # Don't die on dtoa code that uses a char as an array index.
+ # This is required solely for base/third_party/dmg_fp/dtoa.cc.
+ '-Wno-char-subscripts',
+ ],
+ }],
],
},
'target_conditions': [
« no previous file with comments | « no previous file | chrome/browser/autofill/autofill_text_field_mac.mm » ('j') | chrome/browser/cocoa/authorization_util.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698