Mac: clang build

ipc/ipc_channel_posix.cc

 // Copyright (c) 2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ipc/ipc_channel_posix.h"
 
 #include <errno.h>
 #include <fcntl.h>
 #include <stddef.h>
 #include <sys/types.h>
@@ skipping 117 matching lines @@
     int dup_fd = dup(fd);
     if (dup_fd < 0)
       PLOG(FATAL) << "dup(" << fd << ")";
     return dup_fd;
   }
 
   return fd;
 }
 
 //------------------------------------------------------------------------------
-sockaddr_un sizecheck;
-const size_t kMaxPipeNameLength = sizeof(sizecheck.sun_path);
+const size_t kMaxPipeNameLength = sizeof(((sockaddr_un*)0)->sun_path);

[Evan Martin, 2010/09/22 00:03:47]

Is this really the best way to accomplish this?  There's gotta be some fancy
C++ism you could use here...

[Nico, 2010/09/22 00:06:25]

I asked on cfe-dev, and this is what The Chris Lattner recommended. Someone said
that sizeof(sockaddr_un::sun_path) works in c++0x, but…

 
 // Creates a Fifo with the specified name ready to listen on.
 bool CreateServerFifo(const std::string& pipe_name, int* server_listen_fd) {
   DCHECK(server_listen_fd);
   DCHECK_GT(pipe_name.length(), 0u);
   DCHECK_LT(pipe_name.length(), kMaxPipeNameLength);
 
   if (pipe_name.length() == 0 || pipe_name.length() >= kMaxPipeNameLength) {
     return false;
   }
@@ skipping 934 matching lines @@
 
 bool Channel::Send(Message* message) {
   return channel_impl_->Send(message);
 }
 
 int Channel::GetClientFileDescriptor() const {
   return channel_impl_->GetClientFileDescriptor();
 }
 
 }  // namespace IPC