Mac: clang build

chrome/browser/cocoa/authorization_util.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/cocoa/authorization_util.h"
 
 #import <Foundation/Foundation.h>
 #include <sys/wait.h>
 
 #include <string>
@@ skipping 30 matching lines @@
   // product_logo_32.png is used instead of app.icns because Authorization
   // Services can't deal with .icns files.
   NSString* icon_path =
       [mac_util::MainAppBundle() pathForResource:@"product_logo_32"
                                           ofType:@"png"];
   const char* icon_path_c = [icon_path fileSystemRepresentation];
   size_t icon_path_length = icon_path_c ? strlen(icon_path_c) : 0;
 
   // The OS will append " Type an administrator's name and password to allow
   // <CFBundleDisplayName> to make changes."
-  NSString* prompt_ns = reinterpret_cast<const NSString*>(prompt);
+  NSString* prompt_ns = const_cast<NSString*>(

[Mark Mentovai, 2010/09/22 16:38:36]

Double casts are worse, readability-wise, than a C-style cast.

+      reinterpret_cast<const NSString*>(prompt));
   const char* prompt_c = [prompt_ns UTF8String];
   size_t prompt_length = prompt_c ? strlen(prompt_c) : 0;
 
   AuthorizationItem environment_items[] = {
     {kAuthorizationEnvironmentIcon, icon_path_length, (void*)icon_path_c, 0},
     {kAuthorizationEnvironmentPrompt, prompt_length, (void*)prompt_c, 0}
   };
 
   AuthorizationEnvironment environment = {arraysize(environment_items),
                                           environment_items};
@@ skipping 112 matching lines @@
       *exit_status_pointer = -1;
     }
   } else {
     *exit_status_pointer = -1;
   }
 
   return status;
 }
 
 }  // namespace authorization_util