Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1201)

Issue 2762008: Track ascii-ness of data in externalized strings. (Closed)

Created:
10 years, 6 months ago by Vitaly Repeshko
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Track ascii-ness of data in externalized strings. If a two-byte string only contains ascii characters, then we can save memory when flattening a cons string containing it. Similarly we can use this in Array.prototype.join implementation. To track this a new bit is added to instance type. This bit is used as a hint in generated code and in runtime functions. To enable testing a new V8 extension is added controlled by --expose-externalize-string flag. Committed: http://code.google.com/p/v8/source/detail?r=4894

Patch Set 1 #

Patch Set 2 : Extended tests. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+356 lines, -66 lines) Patch
M src/arm/codegen-arm.cc View 2 chunks +15 lines, -1 line 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/execution.h View 1 chunk +12 lines, -1 line 0 comments Download
M src/execution.cc View 2 chunks +111 lines, -3 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap.cc View 1 5 chunks +35 lines, -12 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 3 chunks +15 lines, -1 line 0 comments Download
M src/objects.h View 5 chunks +30 lines, -11 lines 0 comments Download
M src/objects.cc View 3 chunks +10 lines, -2 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +4 lines, -15 lines 1 comment Download
M src/runtime.cc View 5 chunks +5 lines, -16 lines 0 comments Download
M src/x64/codegen-x64.cc View 4 chunks +17 lines, -4 lines 0 comments Download
A test/mjsunit/string-externalize.js View 1 1 chunk +95 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vitaly Repeshko
10 years, 6 months ago (2010-06-10 13:12:53 UTC) #1
Søren Thygesen Gjesse
Drive by comment http://codereview.chromium.org/2762008/diff/3001/4010 File src/objects-inl.h (right): http://codereview.chromium.org/2762008/diff/3001/4010#newcode250 src/objects-inl.h:250: bool String::HasAsciiChars() { HasAsciiChars() -> HasOnlyAsciiChars()?
10 years, 6 months ago (2010-06-10 13:55:46 UTC) #2
Mads Ager (chromium)
10 years, 6 months ago (2010-06-11 06:55:22 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698