Issue 2762001: Wait sending ScreenIsLocked signal until screen lock window is mapped.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2762001: Wait sending ScreenIsLocked signal until screen lock window is mapped. (Closed)

Created:
10 years, 6 months ago by oshima

Modified:
9 years, 6 months ago

Reviewers:
DaveMoore

CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Wait sending ScreenIsLocked signal until screen lock window is mapped. * When closing and opening the lid, chrome window is briefly visible because the computer is suspended before window is fully mapped and covers the screen. BUG=none TEST=manual: close and open the lid shoudl not expose the content of chrome window. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49233

Patch Set 1 #

Total comments: 1

Patch Set 2 : " #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -26 lines)			Patch
	M	chrome/browser/chromeos/login/screen_locker.h	View		3 chunks	+14 lines, -2 lines	0 comments	Download
	M	chrome/browser/chromeos/login/screen_locker.cc	View	1	7 chunks	+49 lines, -24 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

DaveMoore

10 years, 6 months ago (2010-06-08 17:54:28 UTC) #2

LGTM module nit

http://codereview.chromium.org/2762001/diff/1/2
File chrome/browser/chromeos/login/screen_locker.cc (right):

http://codereview.chromium.org/2762001/diff/1/2#newcode369
chrome/browser/chromeos/login/screen_locker.cc:369: if(mapped_)
nit: need space before (

Expand Messages | Collapse Messages