Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: src/x64/codegen-x64.cc

Issue 276018: Fixed use of 'overwrite' flag for unary minus expressions. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/codegen-ia32.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3074 matching lines...) Expand 10 before | Expand all | Expand 10 after
3085 Load(node->expression()); 3085 Load(node->expression());
3086 switch (op) { 3086 switch (op) {
3087 case Token::NOT: 3087 case Token::NOT:
3088 case Token::DELETE: 3088 case Token::DELETE:
3089 case Token::TYPEOF: 3089 case Token::TYPEOF:
3090 UNREACHABLE(); // handled above 3090 UNREACHABLE(); // handled above
3091 break; 3091 break;
3092 3092
3093 case Token::SUB: { 3093 case Token::SUB: {
3094 bool overwrite = 3094 bool overwrite =
3095 (node->AsBinaryOperation() != NULL && 3095 (node->expression()->AsBinaryOperation() != NULL &&
3096 node->AsBinaryOperation()->ResultOverwriteAllowed()); 3096 node->expression()->AsBinaryOperation()->ResultOverwriteAllowed());
3097 UnarySubStub stub(overwrite); 3097 UnarySubStub stub(overwrite);
3098 // TODO(1222589): remove dependency of TOS being cached inside stub 3098 // TODO(1222589): remove dependency of TOS being cached inside stub
3099 Result operand = frame_->Pop(); 3099 Result operand = frame_->Pop();
3100 Result answer = frame_->CallStub(&stub, &operand); 3100 Result answer = frame_->CallStub(&stub, &operand);
3101 frame_->Push(&answer); 3101 frame_->Push(&answer);
3102 break; 3102 break;
3103 } 3103 }
3104 3104
3105 case Token::BIT_NOT: { 3105 case Token::BIT_NOT: {
3106 // Smi check. 3106 // Smi check.
(...skipping 4585 matching lines...) Expand 10 before | Expand all | Expand 10 after
7692 int CompareStub::MinorKey() { 7692 int CompareStub::MinorKey() {
7693 // Encode the two parameters in a unique 16 bit value. 7693 // Encode the two parameters in a unique 16 bit value.
7694 ASSERT(static_cast<unsigned>(cc_) < (1 << 15)); 7694 ASSERT(static_cast<unsigned>(cc_) < (1 << 15));
7695 return (static_cast<unsigned>(cc_) << 1) | (strict_ ? 1 : 0); 7695 return (static_cast<unsigned>(cc_) << 1) | (strict_ ? 1 : 0);
7696 } 7696 }
7697 7697
7698 7698
7699 #undef __ 7699 #undef __
7700 7700
7701 } } // namespace v8::internal 7701 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ia32/codegen-ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698