Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 276016: Remove some deprecated file_util wstring functions. (Closed)

Created:
11 years, 2 months ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
tony
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr., kuchhal, darin (slow to review), tim (not reviewing)
Visibility:
Public.

Description

Remove some deprecated file_util wstring functions. death to the wstring TEST=trybots BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29078

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : lint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -272 lines) Patch
M base/file_util.h View 1 2 3 3 chunks +0 lines, -8 lines 0 comments Download
M base/file_util.cc View 1 2 3 3 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/first_run_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/firefox2_importer.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/firefox3_importer.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/importer/importer_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/jumplist.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/printing/printing_layout_uitest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/navigation_controller_unittest.cc View 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_plugin_util.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/install.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/installer/setup/setup_main.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/installer/util/copy_tree_work_item.h View 3 5 4 chunks +8 lines, -6 lines 0 comments Download
M chrome/installer/util/copy_tree_work_item.cc View 3 6 chunks +27 lines, -26 lines 0 comments Download
M chrome/installer/util/copy_tree_work_item_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/installer/util/delete_after_reboot_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/delete_tree_work_item.h View 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/installer/util/delete_tree_work_item.cc View 4 5 4 chunks +9 lines, -10 lines 0 comments Download
MM chrome/installer/util/move_tree_work_item.h View 6 1 chunk +4 lines, -4 lines 0 comments Download
MM chrome/installer/util/move_tree_work_item.cc View 6 3 chunks +15 lines, -16 lines 0 comments Download
M chrome/installer/util/shell_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/mini_installer_test/chrome_mini_installer.cc View 6 6 chunks +9 lines, -8 lines 0 comments Download
M chrome/test/mini_installer_test/mini_installer_test_util.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/mini_installer_test/run_all_unittests.cc View 1 chunk +7 lines, -9 lines 0 comments Download
M chrome/tools/crash_service/main.cc View 3 4 5 2 chunks +7 lines, -8 lines 0 comments Download
M net/tools/crash_cache/crash_cache.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/vector_canvas_unittest.cc View 6 44 chunks +64 lines, -63 lines 0 comments Download
M tools/memory_watcher/memory_watcher.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/default_plugin/plugin_database_handler.cc View 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/image_decoder_unittest.h View 1 2 3 4 5 6 4 chunks +14 lines, -12 lines 0 comments Download
M webkit/tools/test_shell/image_decoder_unittest.cc View 1 2 3 10 chunks +46 lines, -39 lines 0 comments Download
M webkit/tools/webcore_unit_tests/BMPImageDecoder_unittest.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/webcore_unit_tests/ICOImageDecoder_unittest.cpp View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/tools/webcore_unit_tests/XBMImageDecoder_unittest.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Evan Stade
pain
11 years, 2 months ago (2009-10-14 23:45:06 UTC) #1
tony
LGTM. Nit: In a lot of the Windows only files (like all the installer stuff), ...
11 years, 2 months ago (2009-10-15 01:11:44 UTC) #2
Evan Stade
11 years, 2 months ago (2009-10-15 01:14:41 UTC) #3 
yea, I may have been overzealous in some places, but for the most part the Hack
functions indicate places we should be using FilePaths

Powered by Google App Engine
This is Rietveld 408576698