Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5914)

Unified Diff: chrome/browser/printing/print_view_manager.cc

Issue 276004: Wire up printing on the Mac (Closed)
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/print_view_manager.cc
diff --git a/chrome/browser/printing/print_view_manager.cc b/chrome/browser/printing/print_view_manager.cc
index 22f3abe20b7118e20f745e95027996bae4dd388d..4f6e73a7d2de60c4b3e96c16e574e14466653620 100644
--- a/chrome/browser/printing/print_view_manager.cc
+++ b/chrome/browser/printing/print_view_manager.cc
@@ -24,10 +24,10 @@ using base::TimeDelta;
namespace printing {
PrintViewManager::PrintViewManager(TabContents& owner)
- : owner_(owner),
- waiting_to_print_(false),
+ : waiting_to_print_(false),
printing_succeeded_(false),
- inside_inner_message_loop_(false) {
+ inside_inner_message_loop_(false),
+ owner_(owner) {
}
PrintViewManager::~PrintViewManager() {
@@ -101,6 +101,7 @@ void PrintViewManager::DidPrintPage(
return;
}
+#if defined(OS_WIN)
// http://msdn2.microsoft.com/en-us/library/ms535522.aspx
// Windows 2000/XP: When a page in a spooled file exceeds approximately 350
// MB, it can fail to print and not send an error message.
@@ -110,6 +111,7 @@ void PrintViewManager::DidPrintPage(
owner_.Stop();
return;
}
+#endif
base::SharedMemory shared_buf(params.metafile_data_handle, true);
if (!shared_buf.Map(params.data_size)) {

Powered by Google App Engine
This is Rietveld 408576698