Link with RLZ library from open source repo....

Link with RLZ library from open source repo.

In order to pass the check dependency step in the build, I added rlz to
the include_rules in DEPS.  However, I am not sure this is the best solution.

TEST=Make sure that the RLZ pings from chrome are the sameas they were with
the old RLZ dll
BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49399

[cpu_(ooo_6.6-7.5), 2010-06-08 22:26:54]

How are we loading rlz. I did not see a LoadLibrary.

http://codereview.chromium.org/2755002/diff/1/6
File chrome/browser/rlz/rlz.h (right):

http://codereview.chromium.org/2755002/diff/1/6#newcode25
chrome/browser/rlz/rlz.h:25: // rlz.dll is not present so all the functionality
becomes no-ops.
can you add a comment here about the open source nature of it and the url of the
project?

[cpu_(ooo_6.6-7.5), 2010-06-08 22:31:16]

One nit, please update the copyright year to 2010

On 2010/06/08 22:26:54, cpu wrote:
> How are we loading rlz. I did not see a LoadLibrary.
> 
> http://codereview.chromium.org/2755002/diff/1/6
> File chrome/browser/rlz/rlz.h (right):
> 
> http://codereview.chromium.org/2755002/diff/1/6#newcode25
> chrome/browser/rlz/rlz.h:25: // rlz.dll is not present so all the
functionality
> becomes no-ops.
> can you add a comment here about the open source nature of it and the url of
the
> project?

[Roger Tawa OOO till Jul 10th, 2010-06-09 01:51:08]

On 2010/06/08 22:31:16, cpu wrote:
> One nit, please update the copyright year to 2010
> 
> On 2010/06/08 22:26:54, cpu wrote:
> > How are we loading rlz. I did not see a LoadLibrary.
> > 
> > http://codereview.chromium.org/2755002/diff/1/6
> > File chrome/browser/rlz/rlz.h (right):
> > 
> > http://codereview.chromium.org/2755002/diff/1/6#newcode25
> > chrome/browser/rlz/rlz.h:25: // rlz.dll is not present so all the
> functionality
> > becomes no-ops.
> > can you add a comment here about the open source nature of it and the url of
> the
> > project?

Hi Carlos,

There is no longer a need for LoadLibrary since the rlz code is now compiled
into chrome.dll.  However, the delayed initialization still exists, so this part
of the behaviour is as before.

You were concerned that this would cause wininet to be loaded during chrome
startup, which is a big slow down.  However, tracing through the order of dll
loads with visual studio does not seem to indicate this is the case.  Here is
the dll loading order of the browser process, wrt the points at which key
RLZTracker entry points are called.  This shows that the wininet dll is only
called when the delayed task runs, not at chrome startup, and then only if an
RLZ ping needs to be sent.

Loaded 'D:\src\CHROME\src\chrome\Debug\chrome.exe'
Loaded 'C:\Windows\SysWOW64\ntdll.dll'
Loaded 'C:\Windows\SysWOW64\kernel32.dll'
Loaded 'C:\Windows\SysWOW64\user32.dll'
Loaded 'C:\Windows\SysWOW64\gdi32.dll'
Loaded 'C:\Windows\SysWOW64\advapi32.dll'
Loaded 'C:\Windows\SysWOW64\rpcrt4.dll'
Loaded 'C:\Windows\SysWOW64\secur32.dll'
Loaded 'C:\Windows\SysWOW64\shell32.dll'
Loaded 'C:\Windows\SysWOW64\msvcrt.dll'
Loaded 'C:\Windows\SysWOW64\shlwapi.dll'
Loaded 'C:\Windows\SysWOW64\userenv.dll'
Loaded 'C:\Windows\SysWOW64\winmm.dll'
Loaded 'C:\Windows\SysWOW64\ole32.dll'
Loaded 'C:\Windows\SysWOW64\oleaut32.dll'
Loaded 'C:\Windows\SysWOW64\oleacc.dll'
Loaded 'C:\Windows\SysWOW64\version.dll'
Loaded 'C:\Windows\SysWOW64\psapi.dll'
Loaded 'C:\Windows\SysWOW64\imm32.dll'
Loaded 'C:\Windows\SysWOW64\msctf.dll'
Loaded 'C:\Windows\SysWOW64\lpk.dll'
Loaded 'C:\Windows\SysWOW64\usp10.dll'
Loaded 'C:\Program Files (x86)\Sophos\Sophos Anti-Virus\sophos_detoured.dll'
Loaded
'C:\Windows\winsxs\x86_microsoft.windows.common-controls_6595b64144ccf1df_6.0.6001.18000_none_5cdbaa5a083979cc\comctl32.dll'
Loaded 'D:\src\CHROME\src\chrome\Debug\chrome.dll', Symbols loaded.
Loaded 'C:\Windows\SysWOW64\riched20.dll'
Loaded 'C:\Windows\SysWOW64\opengl32.dll'
Loaded 'C:\Windows\SysWOW64\glu32.dll'
Loaded 'C:\Windows\SysWOW64\ddraw.dll'
Loaded 'C:\Windows\SysWOW64\dciman32.dll'
Loaded 'C:\Windows\SysWOW64\setupapi.dll'
Loaded 'C:\Windows\SysWOW64\dwmapi.dll'
Loaded 'C:\Windows\SysWOW64\wtsapi32.dll'
Loaded 'C:\Windows\SysWOW64\ws2_32.dll'
Loaded 'C:\Windows\SysWOW64\nsi.dll'
Loaded 'D:\src\CHROME\src\chrome\Debug\icudt42.dll', Binary was not built with
debug information.
Loaded 'C:\Windows\SysWOW64\dbghelp.dll'
Loaded 'C:\Windows\SysWOW64\uxtheme.dll'
Loaded 'C:\Windows\SysWOW64\ntmarta.dll'
Loaded 'C:\Windows\SysWOW64\Wldap32.dll'
Loaded 'C:\Windows\SysWOW64\samlib.dll'
Loaded 'C:\Windows\SysWOW64\winsta.dll'
Loaded 'C:\Windows\SysWOW64\KBDUS.DLL'
Unloaded 'C:\Windows\SysWOW64\KBDUS.DLL'
Loaded 'C:\Windows\SysWOW64\IPHLPAPI.DLL'
Loaded 'C:\Windows\SysWOW64\dhcpcsvc.dll'
Loaded 'C:\Windows\SysWOW64\dnsapi.dll'
Loaded 'C:\Windows\SysWOW64\winnsi.dll'
Loaded 'C:\Windows\SysWOW64\dhcpcsvc6.dll'

RLZTracker::InitRlzDelayed

Loaded 'C:\Windows\SysWOW64\mswsock.dll'
Loaded 'C:\Windows\SysWOW64\WSHTCPIP.DLL'
Loaded 'C:\Windows\SysWOW64\wship6.dll'
Loaded 'C:\Windows\SysWOW64\nlaapi.dll'
Loaded 'C:\Windows\SysWOW64\NapiNSP.dll'
Loaded 'C:\Windows\SysWOW64\pnrpnsp.dll'
Loaded 'C:\Windows\SysWOW64\winrnr.dll'
Loaded 'C:\Windows\SysWOW64\rasadhlp.dll'
Loaded 'C:\Windows\SysWOW64\sxs.dll'
Loaded 'C:\Windows\SysWOW64\clbcatq.dll'
Loaded 'C:\Windows\SysWOW64\apphelp.dll'
Loaded 'C:\Windows\SysWOW64\winhttp.dll'
Loaded 'D:\src\CHROME\src\chrome\Debug\gears.dll', Symbols loaded.
Loaded 'C:\Windows\SysWOW64\urlmon.dll'
Loaded 'C:\Windows\SysWOW64\iertutil.dll'
Loaded 'C:\Windows\SysWOW64\crypt32.dll'
Loaded 'C:\Windows\SysWOW64\msasn1.dll'
Loaded 'C:\Windows\SysWOW64\gpapi.dll'
Loaded 'C:\Windows\SysWOW64\SLC.dll'
Loaded 'C:\Windows\SysWOW64\cryptnet.dll'
Loaded 'C:\Windows\SysWOW64\SensApi.dll'
Loaded 'C:\Windows\SysWOW64\netapi32.dll'
Loaded 'C:\Windows\SysWOW64\rsaenh.dll'
Loaded 'C:\Windows\SysWOW64\cabinet.dll'
Loaded 'C:\Windows\SysWOW64\ncrypt.dll'
Loaded 'C:\Windows\SysWOW64\bcrypt.dll'

RLZTracker::SendFinancialPing

Loaded 'C:\Windows\SysWOW64\wininet.dll'
Loaded 'C:\Windows\SysWOW64\normaliz.dll'
Loaded 'C:\Windows\SysWOW64\rasapi32.dll'
Loaded 'C:\Windows\SysWOW64\rasman.dll'
Loaded 'C:\Windows\SysWOW64\tapi32.dll'
Loaded 'C:\Windows\SysWOW64\rtutils.dll'
Loaded 'C:\Windows\SysWOW64\credssp.dll'
Unloaded 'C:\Windows\SysWOW64\credssp.dll'
Loaded 'C:\Windows\SysWOW64\credssp.dll'
Loaded 'C:\Windows\SysWOW64\schannel.dll'
Loaded 'C:\Windows\SysWOW64\jsproxy.dll'
Loaded 'C:\Windows\SysWOW64\jscript.dll'
Unloaded 'D:\src\CHROME\src\chrome\Debug\gears.dll'
Unloaded 'C:\Windows\SysWOW64\jscript.dll'
The program '[14200] chrome.exe: Native' has exited with code 0 (0x0).

[Roger Tawa OOO till Jul 10th, 2010-06-09 01:51:22]

http://codereview.chromium.org/2755002/diff/1/6
File chrome/browser/rlz/rlz.h (right):

http://codereview.chromium.org/2755002/diff/1/6#newcode25
chrome/browser/rlz/rlz.h:25: // rlz.dll is not present so all the functionality
becomes no-ops.
On 2010/06/08 22:26:55, cpu wrote:
> can you add a comment here about the open source nature of it and the url of
the
> project?

Done.

[cpu_(ooo_6.6-7.5), 2010-06-09 17:38:29]

All right, go ahead. Keep an eye on the perf bots, specially the Startup time
one.


On 2010/06/09 01:51:22, Roger Tawa wrote:
> http://codereview.chromium.org/2755002/diff/1/6
> File chrome/browser/rlz/rlz.h (right):
> 
> http://codereview.chromium.org/2755002/diff/1/6#newcode25
> chrome/browser/rlz/rlz.h:25: // rlz.dll is not present so all the
functionality
> becomes no-ops.
> On 2010/06/08 22:26:55, cpu wrote:
> > can you add a comment here about the open source nature of it and the url of
> the
> > project?
> 
> Done.

[Roger Tawa OOO till Jul 10th, 2010-06-09 18:40:29]

On 2010/06/09 17:38:29, cpu wrote:
> All right, go ahead. Keep an eye on the perf bots, specially the Startup time
> one.
> 
> 
> On 2010/06/09 01:51:22, Roger Tawa wrote:
> > http://codereview.chromium.org/2755002/diff/1/6
> > File chrome/browser/rlz/rlz.h (right):
> > 
> > http://codereview.chromium.org/2755002/diff/1/6#newcode25
> > chrome/browser/rlz/rlz.h:25: // rlz.dll is not present so all the
> functionality
> > becomes no-ops.
> > On 2010/06/08 22:26:55, cpu wrote:
> > > can you add a comment here about the open source nature of it and the url
of
> > the
> > > project?
> > 
> > Done.

Thanks Carlos.  Note that I think every test in browser_tests failed, although I
don't think my change could have caused that.  I will investigate this before
committing.