Issue 2754004: Use static type information in ConstantIntBinaryOperation on x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2754004: Use static type information in ConstantIntBinaryOperation on x64. (Closed)

Created:
10 years, 6 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Use static type information in ConstantIntBinaryOperation on x64. Committed: http://code.google.com/p/v8/source/detail?r=4836

Patch Set 2 : '' #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -13 lines)			Patch
	M	src/x64/codegen-x64.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
	M	src/x64/codegen-x64.cc	View		9 chunks	+28 lines, -13 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/2754004/diff/4001/5001 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/2754004/diff/4001/5001#newcode7144 src/x64/codegen-x64.cc:7144: } Is it possible to have a typeinfo ...

10 years, 6 months ago (2010-06-10 10:02:36 UTC) #2

William Hesse

10 years, 6 months ago (2010-06-10 14:40:01 UTC) #3

On 2010/06/10 10:02:36, Lasse Reichstein wrote:
> LGTM
> 
> http://codereview.chromium.org/2754004/diff/4001/5001
> File src/x64/codegen-x64.cc (right):
> 
> http://codereview.chromium.org/2754004/diff/4001/5001#newcode7144
> src/x64/codegen-x64.cc:7144: }
> Is it possible to have a typeinfo that says that the type is definitly not a
> smi?

This should be done in the code that decides whether to call this "LikelySmi"
function.  We don't want to generate inline Smi code in this case.

Expand Messages | Collapse Messages

Issue 2754004: Use static type information in ConstantIntBinaryOperation on x64. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages