Issue 2754003: Add logic from KeyedLoadIC generic stub to KeyedCallIC megamorphic stub....

Issue 2754003: Add logic from KeyedLoadIC generic stub to KeyedCallIC megamorphic stub.... (Closed)

Created:
10 years, 6 months ago by Vladislav Kaznacheev

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add logic from KeyedLoadIC generic stub to KeyedCallIC megamorphic stub. This should make access faster for arrays of functions. Committed: http://code.google.com/p/v8/source/detail?r=4834

Patch Set 2 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+376 lines, -113 lines)			Patch
M	src/ia32/ic-ia32.cc	View	1	13 chunks	+257 lines, -102 lines	0 comments	Download
M	src/ic.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ic.cc	View	1	2 chunks	+14 lines, -10 lines	0 comments	Download
M	src/v8-counters.h	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
A	test/mjsunit/keyed-call-generic.js	View		1 chunk	+96 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/2754003/diff/13001/12004 File src/ia32/ic-ia32.cc (right): http://codereview.chromium.org/2754003/diff/13001/12004#newcode309 src/ia32/ic-ia32.cc:309: Register r0, r0 -> scratch or map? http://codereview.chromium.org/2754003/diff/13001/12004#newcode342 ...

10 years, 6 months ago (2010-06-09 15:08:44 UTC) #2

Vladislav Kaznacheev

10 years, 6 months ago (2010-06-10 05:06:05 UTC) #3

http://codereview.chromium.org/2754003/diff/13001/12004
File src/ia32/ic-ia32.cc (right):

http://codereview.chromium.org/2754003/diff/13001/12004#newcode309
src/ia32/ic-ia32.cc:309: Register r0,
On 2010/06/09 15:08:45, Mads Ager wrote:
> r0 -> scratch or map?

Done.

http://codereview.chromium.org/2754003/diff/13001/12004#newcode342
src/ia32/ic-ia32.cc:342: Register r0,
On 2010/06/09 15:08:45, Mads Ager wrote:
> r0 -> scratch?

Done.

http://codereview.chromium.org/2754003/diff/13001/12004#newcode373
src/ia32/ic-ia32.cc:373: // Checks whether a key is an array index string or a
symbol string.
On 2010/06/09 15:08:45, Mads Ager wrote:
> Could you add a comment that this generates code that falls through if the key
> is a symbol?

Done.

http://codereview.chromium.org/2754003/diff/13001/12004#newcode383
src/ia32/ic-ia32.cc:383: //   r0 - used to hold the map of the key.
On 2010/06/09 15:08:45, Mads Ager wrote:
> r0 -> map?

Done.

http://codereview.chromium.org/2754003/diff/13001/12004#newcode384
src/ia32/ic-ia32.cc:384: //   r1 - used to hold the hash of the key.
On 2010/06/09 15:08:45, Mads Ager wrote:
> r1 -> hash?

Done.

http://codereview.chromium.org/2754003/diff/13001/12004#newcode400
src/ia32/ic-ia32.cc:400: // Picks out an array index from the hash field.
On 2010/06/09 15:08:45, Mads Ager wrote:
> Add a comment that the code generated never falls through?

Done.

http://codereview.chromium.org/2754003/diff/13001/12004#newcode505
src/ia32/ic-ia32.cc:505: KeyedLoadIC::GenerateRuntimeGetProperty(masm);
Removed
On 2010/06/09 15:08:45, Mads Ager wrote:
> Is the KeyedLoadIC:: prefix needed?

Expand Messages | Collapse Messages