Issue 2753005: Infobars on GTK (first part)....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2753005: Infobars on GTK (first part).... (Closed)

Created:
10 years, 6 months ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Infobars on GTK (first part). I got it to a point where we show HTML content from the extension within an infobar, but there are a few things missing. Missing pieces: - Infobar does not size based on the height of its content (between 36px and 72px). - Infobar content always has a fixed width, but needs to fill out into the available infobar area. - I've put in code to asynchronously fetch the image for the Infobar, but it needs to be shown and hooked up to the ExtensionAction context menu (same context menu we use for the browser action container icons). - The background for HTML content should have a gradient, but is just solid blue at the moment. BUG=39916 TEST=Infobars should show up on GTK. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49319

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+126 lines, -2 lines)			Patch
M	chrome/browser/extensions/extension_infobar_delegate.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A	chrome/browser/gtk/extension_infobar_gtk.h	View	1 chunk	+45 lines, -0 lines	0 comments	Download
A	chrome/browser/gtk/extension_infobar_gtk.cc	View	1 chunk	+77 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Finnur

As discussed yesterday, this is the first part of the Infobar support on Linux (GTK). ...

10 years, 6 months ago (2010-06-09 16:21:47 UTC) #1

Elliot Glaysher

10 years, 6 months ago (2010-06-09 17:54:23 UTC) #2

On 2010/06/09 16:21:47, Finnur wrote:
> As discussed yesterday, this is the first part of the Infobar support on Linux
> (GTK). I'm running out of time finishing the rest, but I think this is at a
good
> checkpoint for building on top of this.

This seems good for an incomplete work. LGTM.

Expand Messages | Collapse Messages