Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 2753003: Update SxS/Exp channel name to final name "Canary". (Closed)

Created:
10 years, 6 months ago by mattm
Modified:
9 years, 7 months ago
Reviewers:
huanr
CC:
chromium-reviews, kuchhal
Base URL:
git://codf21.jail/chromium.git
Visibility:
Public.

Description

Update SxS/Exp channel name to final name "Canary". BUG=37129, 38334 TEST=install sxs, check about box, about:version, start menu shortcut name Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49352

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/google_chrome_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/google_chrome_sxs_distribution.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
mattm
two things to note: The start menu/desktop shortcuts don't get updated unless you uninstall first. ...
10 years, 6 months ago (2010-06-09 01:03:39 UTC) #1
huanr
LGTM
10 years, 6 months ago (2010-06-09 21:26:10 UTC) #2
huanr
10 years, 6 months ago (2010-06-09 21:28:05 UTC) #3
On 2010/06/09 01:03:39, mattm wrote:
> two things to note:
> 
> The start menu/desktop shortcuts don't get updated unless you uninstall first.

> Can we live with that?
> 
I think that is probably fine. We can make a note on that when announcing canary
on chromium groups.

> Should the channel name in about dialog be capitalized?  I made it
> non-capitalized for consistency with "beta" and "dev".

Either is fine with me.

Powered by Google App Engine
This is Rietveld 408576698