Issue 2753002: NaCl: Remove call to NaClAppDtor()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2753002: NaCl: Remove call to NaClAppDtor() (Closed)

Created:
10 years, 6 months ago by Mark Seaborn

Modified:
9 years, 5 months ago

Reviewers:
Cliff L. Biffle

CC:
chromium-reviews, native-client-reviews_googlegroups.com, noelallen_use_chromium, gregoryd

Visibility:
Public.

Description

NaCl: Remove call to NaClAppDtor() Calling NaClAppDtor() is unnecessary because the process is about to exit anyway, and it happens only in the error path because NaClAppDtor() is not able to shut down running NaCl threads safely. There is a TODO for its removal in the NaCl tree. This is related to http://codereview.chromium.org/2659002. BUG=http://code.google.com/p/nativeclient/issues/detail?id=560 TEST=nacl_ui_test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49324

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -6 lines)			Patch
	M	chrome/nacl/sel_main.cc	View		2 chunks	+1 line, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages