Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2751007: Add an "ssid_suffix" parameter to both "connect" and "config" rules to modify SSID per-subtest (Closed)

Created:
10 years, 6 months ago by Paul Stewart
Modified:
9 years, 7 months ago
Reviewers:
Sam Leffler
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://gitrw.chromium.org/autotest.git
Visibility:
Public.

Description

Add an "ssid_suffix" parameter to both "connect" and "config" rules to modify SSID per-subtest TEST=ran autotests BUG=

Patch Set 1 #

Patch Set 2 : Fixup to default ssid for connect command -- use router configured ssid; add bsd router #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M server/site_bsd_router.py View 3 chunks +6 lines, -1 line 0 comments Download
M server/site_linux_router.py View 1 3 chunks +7 lines, -0 lines 0 comments Download
M server/site_wifitest.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Paul Stewart
10 years, 6 months ago (2010-06-10 21:16:46 UTC) #1
Sam Leffler
Is there a reason to do this for _both_ connect+config? Seems like you want to ...
10 years, 6 months ago (2010-06-10 21:23:40 UTC) #2
Paul Stewart
Here's a proposed way to not duplicate for connect+config -- read the ssid out of ...
10 years, 6 months ago (2010-06-10 21:48:16 UTC) #3
Paul Stewart
10 years, 6 months ago (2010-06-10 21:48:26 UTC) #4
Sam Leffler
10 years, 6 months ago (2010-06-10 21:56:28 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698