Issue 2751001: gtk: Populate the AutoFill billing address combobox with profile labels. Also

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2751001: gtk: Populate the AutoFill billing address combobox with profile labels. Also (Closed)

Created:
10 years, 6 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
GeorgeY

CC:
chromium-reviews, ben+cc_chromium.org

Visibility:
Public.

Description

gtk: Populate the AutoFill billing address combobox with profile labels. Also remove handling of the default profile, which is no longer a part of the feature. BUG=41645 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49226

Patch Set 1 #

Total comments: 2

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -177 lines)			Patch
	M	chrome/browser/autofill/autofill_dialog_gtk.cc	View		23 chunks	+66 lines, -177 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

GeorgeY

LGTM http://codereview.chromium.org/2751001/diff/1/2 File chrome/browser/autofill/autofill_dialog_gtk.cc (right): http://codereview.chromium.org/2751001/diff/1/2#newcode303 chrome/browser/autofill/autofill_dialog_gtk.cc:303: GtkWidget* AddNewAddress(bool expand); Do we still need an ...

10 years, 6 months ago (2010-06-08 23:12:15 UTC) #3

James Hawkins

10 years, 6 months ago (2010-06-08 23:14:22 UTC) #4

http://codereview.chromium.org/2751001/diff/1/2
File chrome/browser/autofill/autofill_dialog_gtk.cc (right):

http://codereview.chromium.org/2751001/diff/1/2#newcode303
chrome/browser/autofill/autofill_dialog_gtk.cc:303: GtkWidget*
AddNewAddress(bool expand);
On 2010/06/08 23:12:15, GeorgeY wrote:
> Do we still need an |expand|?

Yes, this is still the old implementation.

Expand Messages | Collapse Messages