Issue 275016: Fix overflow in failure "requested size" field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 275016: Fix overflow in failure "requested size" field. (Closed)

Created:
11 years, 2 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Visibility:
Public.

Description

Fix overflow in failure "requested size" field.

Patch Set 1 #

Total comments: 2

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -19 lines)			Patch
M	src/objects.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/objects.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/objects-inl.h	View	2 chunks	+14 lines, -12 lines	0 comments	Download
M	src/string-stream.h	View	1 chunk	+1 line, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

LGTM. http://codereview.chromium.org/275016/diff/1/5 File src/string-stream.h (right): http://codereview.chromium.org/275016/diff/1/5#newcode108 Line 108: int64_t u_long_; Why this change? Doesn't it ...

11 years, 2 months ago (2009-10-14 08:17:06 UTC) #2

Lasse Reichstein

11 years, 2 months ago (2009-10-14 08:49:52 UTC) #3

http://codereview.chromium.org/275016/diff/1/5
File src/string-stream.h (right):

http://codereview.chromium.org/275016/diff/1/5#newcode108
Line 108: int64_t u_long_;
Well spotted. I started adding a long type, but dropped it again. This line
should be removed as well.

Expand Messages | Collapse Messages