Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 275016: Fix overflow in failure "requested size" field. (Closed)

Created:
11 years, 2 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix overflow in failure "requested size" field.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -19 lines) Patch
M src/objects.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects-inl.h View 2 chunks +14 lines, -12 lines 0 comments Download
M src/string-stream.h View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein
Minor review.
11 years, 2 months ago (2009-10-14 07:10:12 UTC) #1
Kevin Millikin (Chromium)
LGTM. http://codereview.chromium.org/275016/diff/1/5 File src/string-stream.h (right): http://codereview.chromium.org/275016/diff/1/5#newcode108 Line 108: int64_t u_long_; Why this change? Doesn't it ...
11 years, 2 months ago (2009-10-14 08:17:06 UTC) #2
Lasse Reichstein
11 years, 2 months ago (2009-10-14 08:49:52 UTC) #3
http://codereview.chromium.org/275016/diff/1/5
File src/string-stream.h (right):

http://codereview.chromium.org/275016/diff/1/5#newcode108
Line 108: int64_t u_long_;
Well spotted. I started adding a long type, but dropped it again. This line
should be removed as well.

Powered by Google App Engine
This is Rietveld 408576698