Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3330)

Unified Diff: chrome/browser/extensions/extensions_service.cc

Issue 275007: Update page action manifest parsing to match the new format. (Closed)
Patch Set: cleanup Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_process_manager.cc ('k') | chrome/browser/gtk/location_bar_view_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extensions_service.cc
diff --git a/chrome/browser/extensions/extensions_service.cc b/chrome/browser/extensions/extensions_service.cc
index f65e6ffeb2a898afda78f115d657b01e1f5ae8c6..0ff31f828d68ab4677440a0726b3d21251f210eb 100644
--- a/chrome/browser/extensions/extensions_service.cc
+++ b/chrome/browser/extensions/extensions_service.cc
@@ -374,11 +374,9 @@ std::vector<ExtensionAction*> ExtensionsService::GetExtensionActions(
for (ExtensionList::const_iterator iter = extensions_.begin();
iter != extensions_.end(); ++iter) {
if (action_type == ExtensionAction::PAGE_ACTION) {
- const ExtensionActionMap* page_actions = &(*iter)->page_actions();
- for (ExtensionActionMap::const_iterator i(page_actions->begin());
- i != page_actions->end(); ++i) {
- if (include_popups || !i->second->is_popup())
- result.push_back(i->second);
+ ExtensionAction* page_action = (*iter)->page_action();
+ if (page_action && (include_popups || !page_action->is_popup())) {
+ result.push_back(page_action);
}
} else {
ExtensionAction* browser_action = (*iter)->browser_action();
« no previous file with comments | « chrome/browser/extensions/extension_process_manager.cc ('k') | chrome/browser/gtk/location_bar_view_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698