chrome/browser/extensions/extension_page_actions_module.cc - Issue 275007: Update page action manifest parsing to match the new format.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_page_actions_module.cc

Issue 275007: Update page action manifest parsing to match the new format. (Closed)

Patch Set: cleanup Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_page_actions_module.cc

diff --git a/chrome/browser/extensions/extension_page_actions_module.cc b/chrome/browser/extensions/extension_page_actions_module.cc

index 446a91d24c3634d6fa3e03500dd05846d2338c6d..51866e3d1bf780c30c7dd94acb4b8a405e6b4231 100644

--- a/chrome/browser/extensions/extension_page_actions_module.cc

+++ b/chrome/browser/extensions/extension_page_actions_module.cc

@@ -71,9 +71,7 @@ bool PageActionFunction::SetPageActionEnabled(bool enable) {

return false;

}

- const ExtensionAction* page_action =

- extension->GetExtensionAction(page_action_id,

- ExtensionAction::PAGE_ACTION);

+ const ExtensionAction* page_action = extension->page_action();

if (!page_action) {

error_ = ExtensionErrorUtils::FormatErrorMessage(keys::kNoPageActionError,

page_action_id);