Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: chrome/browser/extensions/extension_browser_actions_api.cc

Issue 275007: Update page action manifest parsing to match the new format. (Closed)
Patch Set: cleanup Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_browser_event_router.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_browser_actions_api.cc
diff --git a/chrome/browser/extensions/extension_browser_actions_api.cc b/chrome/browser/extensions/extension_browser_actions_api.cc
index 75ec0896bee0af13c6127cc57e9289a3015b56e6..0a940266ebaecbd7e0b3c94ed341fa5f1d65a005 100644
--- a/chrome/browser/extensions/extension_browser_actions_api.cc
+++ b/chrome/browser/extensions/extension_browser_actions_api.cc
@@ -28,8 +28,8 @@ const char kIconIndexOutOfBounds[] =
}
bool BrowserActionSetNameFunction::RunImpl() {
- std::string name;
- EXTENSION_FUNCTION_VALIDATE(args_->GetAsString(&name));
+ std::string title;
+ EXTENSION_FUNCTION_VALIDATE(args_->GetAsString(&title));
Extension* extension = dispatcher()->GetExtension();
if (!extension->browser_action()) {
@@ -37,7 +37,7 @@ bool BrowserActionSetNameFunction::RunImpl() {
return false;
}
- extension->browser_action_state()->set_title(name);
+ extension->browser_action_state()->set_title(title);
NotificationService::current()->Notify(
NotificationType::EXTENSION_BROWSER_ACTION_UPDATED,
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_browser_event_router.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698