Issue 2749020: Adding a way to mock WebURLLoader in webkit_support....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2749020: Adding a way to mock WebURLLoader in webkit_support.... (Closed)

Created:
10 years, 6 months ago by Jay Civelli

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, darin-cc_chromium.org, tkent, tony

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Adding a way to mock WebURLLoader in webkit_support. This was originally in a CL in Webkit (https://bugs.webkit.org/show_bug.cgi?id=39456) but seems to make more sense in webkit_support. BUG=None TEST=None (the above CL makes use of this). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50382

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Total comments: 1

Patch Set 8 : '' #

Patch Set 9 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+440 lines, -34 lines)			Patch
M	webkit/support/test_webkit_client.h	View	1 2 3 4 5 6 7	3 chunks	+4 lines, -18 lines	0 comments	Download
M	webkit/support/test_webkit_client.cc	View	1 2 3 4 5 6 7	3 chunks	+4 lines, -4 lines	0 comments	Download
M	webkit/support/webkit_support.h	View	1 2 3 4 5 6 7	4 chunks	+26 lines, -3 lines	0 comments	Download
M	webkit/support/webkit_support.cc	View	1 2 3 4 5 6 7	5 chunks	+37 lines, -9 lines	0 comments	Download
M	webkit/support/webkit_support.gypi	View	1 2 3 4 5 6 7	1 chunk	+4 lines, -0 lines	0 comments	Download
A	webkit/support/weburl_loader_mock.h	View	1 2 3 4 5	1 chunk	+57 lines, -0 lines	0 comments	Download
A	webkit/support/weburl_loader_mock.cc	View	1 2 3 4 5	1 chunk	+73 lines, -0 lines	0 comments	Download
A	webkit/support/weburl_loader_mock_factory.h	View	1 2 3 4 5	1 chunk	+99 lines, -0 lines	0 comments	Download
A	webkit/support/weburl_loader_mock_factory.cc	View	1 2 3 4 5 6 7	1 chunk	+136 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jay Civelli

As discussed on Friday, making the URL mock related methods part of webkit_support (so that ...

10 years, 6 months ago (2010-06-14 21:43:47 UTC) #2

darin (slow to review)

10 years, 6 months ago (2010-06-14 21:55:10 UTC) #3

LGTM

http://codereview.chromium.org/2749020/diff/43001/44008
File webkit/support/weburl_loader_mock_factory.cc (right):

http://codereview.chromium.org/2749020/diff/43001/44008#newcode58
webkit/support/weburl_loader_mock_factory.cc:58: WebURLLoaderMock* loader =
iter->first;
nit: indent by only 2 spaces

Expand Messages | Collapse Messages