Split sign.sh into two pieces

Split sign.sh into two pieces to allow the contents of the versioned directory
to be signed independently of the outer browser application bundle.

BUG=45017
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49552

[TVL, 2010-06-10 19:53:27]

http://codereview.chromium.org/2749014/diff/1/4
File chrome/installer/mac/make_signers.sh (right):

http://codereview.chromium.org/2749014/diff/1/4#newcode27
chrome/installer/mac/make_signers.sh:27: ME="$(basename "${0}")"
readonly on any of these?

http://codereview.chromium.org/2749014/diff/1/4#newcode41
chrome/installer/mac/make_signers.sh:41:
browser_app_rules_in_file="${script_dir}/app_resource_rules.plist.in"
would an array be better since you have to loop below?

http://codereview.chromium.org/2749014/diff/1/6
File chrome/installer/mac/sign_app.sh.in (right):

http://codereview.chromium.org/2749014/diff/1/6#newcode24
chrome/installer/mac/sign_app.sh.in:24: ME="$(basename "${0}")"
any readonly?

http://codereview.chromium.org/2749014/diff/1/6#newcode55
chrome/installer/mac/sign_app.sh.in:55: codesign -v "${helper_app}"
why check framework and helper since you don't touch them?

http://codereview.chromium.org/2749014/diff/1/7
File chrome/installer/mac/sign_versioned_dir.sh.in (right):

http://codereview.chromium.org/2749014/diff/1/7#newcode23
chrome/installer/mac/sign_versioned_dir.sh.in:23: ME="$(basename "${0}")"
readonly?

[Mark Mentovai, 2010-06-10 22:08:53]

I also got rid of the echoes, because generate_dmgs was getting too noisy with
them in place.

http://codereview.chromium.org/2749014/diff/1/4
File chrome/installer/mac/make_signers.sh (right):

http://codereview.chromium.org/2749014/diff/1/4#newcode27
chrome/installer/mac/make_signers.sh:27: ME="$(basename "${0}")"
TVL wrote:
> readonly on any of these?

I made all of the ME variables readonly, but I didn’t change anything else. I
didn’t really make anything else readonly in the other scripts. These scripts
weren’t really long enough to justify a main() - if there had been a main(), the
other variables would have just been local.

http://codereview.chromium.org/2749014/diff/1/4#newcode41
chrome/installer/mac/make_signers.sh:41:
browser_app_rules_in_file="${script_dir}/app_resource_rules.plist.in"
TVL wrote:
> would an array be better since you have to loop below?

Yup.

http://codereview.chromium.org/2749014/diff/1/6
File chrome/installer/mac/sign_app.sh.in (right):

http://codereview.chromium.org/2749014/diff/1/6#newcode55
chrome/installer/mac/sign_app.sh.in:55: codesign -v "${helper_app}"
TVL wrote:
> why check framework and helper since you don't touch them?

Sanity! I made the comment say so.

[TVL, 2010-06-11 12:39:34]

lgtm