Issue 2746010: Proper handling of org.chromium.flimflam.Error.InProgress, dbus exception

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2746010: Proper handling of org.chromium.flimflam.Error.InProgress, dbus exception (Closed)

Created:
10 years, 6 months ago by Paul Stewart

Modified:
9 years, 7 months ago

Reviewers:
Sam Leffler

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://gitrw.chromium.org/autotest.git

Visibility:
Public.

Description

Proper handling of org.chromium.flimflam.Error.InProgress, dbus exception

Patch Set 1 #

Patch Set 2 : Change the sleep during "in progress" errors #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -9 lines)			Patch
	M	server/site_wlan_connect.py	View	1	2 chunks	+16 lines, -9 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sam Leffler

10 years, 6 months ago (2010-06-11 22:11:01 UTC) #2

LGTM

http://codereview.chromium.org/2746010/diff/3001/4001
File server/site_wlan_connect.py (right):

http://codereview.chromium.org/2746010/diff/3001/4001#newcode96
server/site_wlan_connect.py:96: time.sleep(5)
These arbitrary sleeps will skew results.  But I guess they're ok for now while
we fix the root cause of the problem(s).

Expand Messages | Collapse Messages