Issue 2746005: Cleanup: Fix an innacurate test name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2746005: Cleanup: Fix an innacurate test name. (Closed)

Created:
10 years, 6 months ago by eroman

Modified:
9 years, 6 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Cleanup: Fix an innacurate test name. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49292

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/net/chrome_url_request_context_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

10 years, 6 months ago (2010-06-08 23:52:41 UTC) #2

LGTM

On Tue, Jun 8, 2010 at 4:51 PM,  <eroman@chromium.org> wrote:
> Reviewers: willchan,
>
> Message:
> (changed the case).
>
> Description:
> Cleanup: Fix an innacurate test name.
>
>
> Please review this at http://codereview.chromium.org/2746005/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/net/chrome_url_request_context_unittest.cc
>
>
> Index: chrome/browser/net/chrome_url_request_context_unittest.cc
> ===================================================================
> --- chrome/browser/net/chrome_url_request_context_unittest.cc   (revision
> 49211)
> +++ chrome/browser/net/chrome_url_request_context_unittest.cc   (working
> copy)
> @@ -14,7 +14,7 @@
>  // Builds an identifier for each test in an array.
>  #define TEST_DESC(desc) StringPrintf("at line %d <%s>", __LINE__, desc)
>
> -TEST(ChromeUrlRequestContextTest, CreateProxyConfigTest) {
> +TEST(ChromeURLRequestContextTest, CreateProxyConfigTest) {
>   FilePath unused_path(FILE_PATH_LITERAL("foo.exe"));
>   // Build the input command lines here.
>   CommandLine empty(unused_path);
>
>
>

Expand Messages | Collapse Messages