Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: vboot_firmware/include/load_kernel_fw.h

Issue 2745007: Major refactoring of structures, with unit tests. (Closed) Base URL: ssh://gitrw.chromium.org/vboot_reference.git
Patch Set: Implemented LoadFirmware2() Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« host/lib/host_key.c ('K') | « vboot_firmware/include/load_firmware_fw.h ('k') | vboot_firmware/lib/cryptolib/include/rsa.h » ('j') | vboot_firmware/lib/include/vboot_firmware.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vboot_firmware/include/load_kernel_fw.h
diff --git a/vboot_firmware/include/load_kernel_fw.h b/vboot_firmware/include/load_kernel_fw.h
index 77e5d50c1c79281f5c541dacff5dedc79b44ca1e..3df5ef964c7a25edf795468d5fdd593c6db1db3b 100644
--- a/vboot_firmware/include/load_kernel_fw.h
+++ b/vboot_firmware/include/load_kernel_fw.h
@@ -19,10 +19,9 @@
#define LOAD_KERNEL_INVALID 2 /* Only invalid kernels found on device */
#define LOAD_KERNEL_RECOVERY 3 /* Internal error; reboot to recovery mode */
-/* Boot modes for LoadKernel() */
-#define BOOT_MODE_NORMAL 0
-#define BOOT_MODE_DEVELOPER 1
-#define BOOT_MODE_RECOVERY 2
+/* Boot flags for LoadKernel().boot_flags */
+#define BOOT_FLAG_DEVELOPER 0x01ULL /* Developer switch is on */
gauravsh 2010/06/10 14:44:13 unsigned long long is not guaranteed to be uint64_
+#define BOOT_FLAG_RECOVERY 0x02ULL /* In recovery mode */
typedef struct LoadKernelParams {
/* Inputs to LoadKernel() */
@@ -33,7 +32,7 @@ typedef struct LoadKernelParams {
void *kernel_buffer; /* Destination buffer for kernel
* (normally at 0x100000) */
uint64_t kernel_buffer_size; /* Size of kernel buffer in bytes */
- uint8_t boot_mode; /* Boot mode */
+ uint64_t boot_flags; /* Boot flags */
/* Outputs from LoadKernel(); valid only if LoadKernel() returns
* LOAD_KERNEL_SUCCESS */
« host/lib/host_key.c ('K') | « vboot_firmware/include/load_firmware_fw.h ('k') | vboot_firmware/lib/cryptolib/include/rsa.h » ('j') | vboot_firmware/lib/include/vboot_firmware.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698