Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: src/profile-generator.h

Issue 2745002: Move token-related constants from CodeEntry to TokenEnumerator. (Closed)
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/cpu-profiler.cc ('k') | src/profile-generator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 23 matching lines...) Expand all
34 34
35 namespace v8 { 35 namespace v8 {
36 namespace internal { 36 namespace internal {
37 37
38 class TokenEnumerator { 38 class TokenEnumerator {
39 public: 39 public:
40 TokenEnumerator(); 40 TokenEnumerator();
41 ~TokenEnumerator(); 41 ~TokenEnumerator();
42 int GetTokenId(Object* token); 42 int GetTokenId(Object* token);
43 43
44 static const int kNoSecurityToken = -1;
45 static const int kInheritsSecurityToken = -2;
46
44 private: 47 private:
45 static void TokenRemovedCallback(v8::Persistent<v8::Value> handle, 48 static void TokenRemovedCallback(v8::Persistent<v8::Value> handle,
46 void* parameter); 49 void* parameter);
47 void TokenRemoved(Object** token_location); 50 void TokenRemoved(Object** token_location);
48 51
49 List<Object**> token_locations_; 52 List<Object**> token_locations_;
50 List<bool> token_removed_; 53 List<bool> token_removed_;
51 54
52 friend class TokenEnumeratorTester; 55 friend class TokenEnumeratorTester;
53 }; 56 };
(...skipping 17 matching lines...) Expand all
71 INLINE(const char* resource_name() const) { return resource_name_; } 74 INLINE(const char* resource_name() const) { return resource_name_; }
72 INLINE(int line_number() const) { return line_number_; } 75 INLINE(int line_number() const) { return line_number_; }
73 INLINE(unsigned call_uid() const) { return call_uid_; } 76 INLINE(unsigned call_uid() const) { return call_uid_; }
74 INLINE(int security_token_id() const) { return security_token_id_; } 77 INLINE(int security_token_id() const) { return security_token_id_; }
75 78
76 INLINE(static bool is_js_function_tag(Logger::LogEventsAndTags tag)); 79 INLINE(static bool is_js_function_tag(Logger::LogEventsAndTags tag));
77 80
78 void CopyData(const CodeEntry& source); 81 void CopyData(const CodeEntry& source);
79 82
80 static const char* kEmptyNamePrefix; 83 static const char* kEmptyNamePrefix;
81 static const int kNoSecurityToken = -1;
82 static const int kInheritsSecurityToken = -2;
83 84
84 private: 85 private:
85 unsigned call_uid_; 86 unsigned call_uid_;
86 Logger::LogEventsAndTags tag_; 87 Logger::LogEventsAndTags tag_;
87 const char* name_prefix_; 88 const char* name_prefix_;
88 const char* name_; 89 const char* name_;
89 const char* resource_name_; 90 const char* resource_name_;
90 int line_number_; 91 int line_number_;
91 int security_token_id_; 92 int security_token_id_;
92 93
(...skipping 302 matching lines...) Expand 10 before | Expand all | Expand 10 after
395 SampleRateCalculator sample_rate_calc_; 396 SampleRateCalculator sample_rate_calc_;
396 397
397 DISALLOW_COPY_AND_ASSIGN(ProfileGenerator); 398 DISALLOW_COPY_AND_ASSIGN(ProfileGenerator);
398 }; 399 };
399 400
400 } } // namespace v8::internal 401 } } // namespace v8::internal
401 402
402 #endif // ENABLE_LOGGING_AND_PROFILING 403 #endif // ENABLE_LOGGING_AND_PROFILING
403 404
404 #endif // V8_PROFILE_GENERATOR_H_ 405 #endif // V8_PROFILE_GENERATOR_H_
OLDNEW
« no previous file with comments | « src/cpu-profiler.cc ('k') | src/profile-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698