Preparation CL for adding crash metrics UMA counters to ChromeFrame. Basicall...

Preparation CL for adding crash metrics UMA counters to ChromeFrame. Basically this would mean that metrics reporting would be done directly
by ChromeFrame. Currently ChromeFrame uses Chrome to upload this data. 

Refactored the chrome metrics service and metrics logging functionality into base classes defined in chrome\common\metrics_helpers.cc/.h. While
this refactoring is by no means complete it is a first step to avoid needless code duplication between chrome and chrome frame.

Bug=46057
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49354

[amit, 2010-06-08 21:07:52]

lgtm

http://codereview.chromium.org/2744003/diff/35001/36003
File chrome/browser/metrics/metrics_service.cc (right):

http://codereview.chromium.org/2744003/diff/35001/36003#newcode577
chrome/browser/metrics/metrics_service.cc:577: MetricsLog* current_log =
static_cast<MetricsLog*>(current_log_);
Would it be better to add things like RecordOmniboxOpenedURL to the base
interface rather than hacky down cast?

[joth, 2010-06-10 10:52:37]

http://codereview.chromium.org/2744003/diff/1008/49005
File chrome/browser/metrics/metrics_log.cc (left):

http://codereview.chromium.org/2744003/diff/1008/49005#oldcode105
chrome/browser/metrics/metrics_log.cc:105:
UnsignedChar(hardware_class_.c_str()));
I think your change has reverted this code (added in r49197) meaning its test
now fails on CrOS:
http://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20(Chro...