Issue 2743007: Properly escape user input for notifications, since URL-encoded characters ar...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2743007: Properly escape user input for notifications, since URL-encoded characters ar... (Closed)

Created:
10 years, 6 months ago by John Gregg

Modified:
9 years ago

Reviewers:
Andrew T Wilson (Slow)

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Properly escape user input for notifications, since URL-encoded characters are leaking through as HTML in non-HTML notifications. BUG=45859 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49328

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -12 lines)			Patch
	M	chrome/browser/notifications/desktop_notification_service.cc	View	1 2	2 chunks	+11 lines, -11 lines	0 comments	Download
	M	chrome/browser/notifications/desktop_notifications_unittest.cc	View		2 chunks	+4 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

John Gregg

new patch posted which addresses your offline comments

10 years, 6 months ago (2010-06-09 20:28:50 UTC) #2

LGTM